Date: Tue, 04 Jul 2017 17:28:13 +0200
Message-ID: <s5hy3s4dxwy.wl-tiwai@suse.de>
From: Takashi Iwai <tiwai@suse.de>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: Chris Wilson <chris@chris-wilson.co.uk>,
        Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
        Guneshwor Singh <guneshwor.o.singh@intel.com>,
        Hardik T Shah <hardik.t.shah@intel.com>,
        Libin Yang <libin.yang@intel.com>,
        "Subhransu S. Prusty" <subhransu.s.prusty@intel.com>,
        Vinod Koul <vinod.koul@intel.com>, Julia Lawall <Julia.Lawall@lip6.fr>,
        Jaroslav Kysela <perex@perex.cz>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] BUG-REPORT: snd-hda: hacked-together EPROBE_DEFER support
In-Reply-To: <CAKMK7uE_Tb9OHKMjnNN-=Jf7VHeZTa1MaO0sL7MGsa2-e1rxZg@mail.gmail.com>
References: <1498057734-14622-1-git-send-email-daniel.vetter@ffwll.ch>
        <149805863799.15021.15278760577807511996@mail.alporthouse.com>
        <s5hbmphs6il.wl-tiwai@suse.de>
        <20170626161630.u4ubdzgxr37o63ip@phenom.ffwll.local>
        <s5h4lv2y728.wl-tiwai@suse.de>
        <CAKMK7uE9-yYRHwhhg5ayWi0nkf8mD3_umXWWozCgoNbFYtmFsg@mail.gmail.com>
        <s5ha84sl8ni.wl-tiwai@suse.de>
        <20170629102559.al74da7xhcdpahbb@phenom.ffwll.local>
        <CAKMK7uE_Tb9OHKMjnNN-=Jf7VHeZTa1MaO0sL7MGsa2-e1rxZg@mail.gmail.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.2
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1235
Lines: 32

On Tue, 04 Jul 2017 17:14:39 +0200,
Daniel Vetter wrote:
> 
> On Thu, Jun 29, 2017 at 12:25 PM, Daniel Vetter <daniel@ffwll.ch> wrote:
> >> Now I took a closer look, and this appears rather like a brown paper
> >> bag bug, not about the deferred probe or module dependency.
> >> The fix patch is below.  Could you check whether it works?
> >
> > Yay, this works!
> >
> > Tested-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> 
> Next one: i915 module reloading is broken because something is holding
> onto a module reference and doesn't drop it. Didn't check which sets
> of patches introduced this, but iirc this worked last week. Disabling
> hda-intel gets in Kconfig gets rid of the problem, so I assume
> something in the sound driver is leaking that reference ...
> 
> It's also causing lots and lots of red in our CI :( If we can't fix
> this we need to disable snd-hda-intel there too.

I spotted out a typo in my previous patch that leads to the module
reference unbalance.  The fix is  already in sound.git tree today:
  https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git/commit/?h=for-linus&id=fc18282cdcba984ab89c74d7e844c10114ae0795

The bug was introduced after 4.12.


thanks,

--
Takashi Iwai <tiwai@suse.de>