From: Lawrence Brakmo <brakmo@fb.com>
To: Daniel Borkmann <daniel@iogearbox.net>,
        Colin King <colin.king@canonical.com>,
        Alexei Starovoitov <ast@kernel.org>,
        "David S . Miller" <davem@davemloft.net>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>
CC: "kernel-janitors@vger.kernel.org" <kernel-janitors@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH][bpf-next] bpf: add missing break in for the
 TCP_BPF_SNDCWND_CLAMP case
Thread-Topic: [PATCH][bpf-next] bpf: add missing break in for the
 TCP_BPF_SNDCWND_CLAMP case
Thread-Index: AQHS9Nk1CHIGkqFmKU6VCtA/JRiz4qJDyiqA//+86oA=
Date: Tue, 4 Jul 2017 18:26:34 +0000
Message-ID: <385C64DB-4BF4-4AC1-B7F0-76AB30969682@fb.com>
References: <20170704152112.18623-1-colin.king@canonical.com>
 <595BB3AF.3000304@iogearbox.net>
In-Reply-To: <595BB3AF.3000304@iogearbox.net>
Accept-Language: en-US
Content-Language: en-US
user-agent: Microsoft-MacOutlook/f.23.0.170610
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="utf-8"
Content-ID: <5FAD45A869CEA3448391CC6ED6BC3521@namprd15.prod.outlook.com>
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Jul 2017 18:26:34.6071
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR15MB1671
X-OriginatorOrg: fb.com
X-Proofpoint-Spam-Reason: safe
X-FB-Internal: Safe
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-07-04_11:,,
 signatures=0
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id v64IRAej019633
Content-Length: 1390
Lines: 42


On 7/4/17, 8:26 AM, "netdev-owner@vger.kernel.org on behalf of Daniel Borkmann" <netdev-owner@vger.kernel.org on behalf of daniel@iogearbox.net> wrote:

    [ +Lawrence ]
    
    On 07/04/2017 05:21 PM, Colin King wrote:
    > From: Colin Ian King <colin.king@canonical.com>
    >
    > There appears to be a missing break in the TCP_BPF_SNDCWND_CLAMP case.
    > Currently the non-error path where val is greater than zero falls through
    > to the default case that sets the error return to -EINVAL. Add in
    > the missing break.
    >
    > Detected by CoverityScan, CID#1449376 ("Missing break in switch")
    >
    > Fixes: 13bf96411ad2 ("bpf: Adds support for setting sndcwnd clamp")
    > Signed-off-by: Colin Ian King <colin.king@canonical.com>
    
    Acked-by: Daniel Borkmann daniel@iogearbox.net
Acked-by: Lawrence Brakmo <brakmo@fb.com>
    
    > ---
    >   net/core/filter.c | 1 +
    >   1 file changed, 1 insertion(+)
    >
    > diff --git a/net/core/filter.c b/net/core/filter.c
    > index 94169572d002..c7f737058d89 100644
    > --- a/net/core/filter.c
    > +++ b/net/core/filter.c
    > @@ -2867,6 +2867,7 @@ BPF_CALL_5(bpf_setsockopt, struct bpf_sock_ops_kern *, bpf_sock,
    >   					tp->snd_cwnd_clamp = val;
    >   					tp->snd_ssthresh = val;
    >   				}
    > +				break;
    >   			default:
    >   				ret = -EINVAL;
    >   			}
    >