Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752228AbdGDTiE (ORCPT <rfc822;w@1wt.eu>);
        Tue, 4 Jul 2017 15:38:04 -0400
Received: from smtp07.smtpout.orange.fr ([80.12.242.129]:26838 "EHLO
        smtp.smtpout.orange.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752052AbdGDTiD (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 4 Jul 2017 15:38:03 -0400
X-ME-Helo: belgarion
X-ME-Auth: amFyem1pay5yb2JlcnRAb3JhbmdlLmZy
X-ME-Date: Tue, 04 Jul 2017 21:38:01 +0200
X-ME-IP: 109.214.174.106
From: Robert Jarzmik <robert.jarzmik@free.fr>
To: Takashi Iwai <tiwai@suse.de>
Cc: "Dmitry Torokhov" <dmitry.torokhov@gmail.com>,
        "Haojian Zhuang" <haojian.zhuang@gmail.com>,
        "Liam Girdwood" <lgirdwood@gmail.com>,
        "Mark Brown" <broonie@kernel.org>, "Lee Jones" <lee.jones@linaro.org>,
        "Lars-Peter Clausen" <lars@metafoo.de>,
        "Charles Keepax" <ckeepax@opensource.wolfsonmicro.com>,
        "Jaroslav Kysela" <perex@perex.cz>, "Daniel Mack" <daniel@zonque.org>,
        <alsa-devel@alsa-project.org>, <linux-arm-kernel@lists.infradead.org>,
        <patches@opensource.wolfsonmicro.com>, <linux-input@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 02/12] ALSA: ac97: add an ac97 bus
References: <20170630194408.24978-1-robert.jarzmik@free.fr>
        <20170630194408.24978-3-robert.jarzmik@free.fr>
        <s5hpodhc28v.wl-tiwai@suse.de>
X-URL: http://belgarath.falguerolles.org/
Date: Tue, 04 Jul 2017 21:37:48 +0200
In-Reply-To: <s5hpodhc28v.wl-tiwai@suse.de> (Takashi Iwai's message of "Mon,
        03 Jul 2017 11:13:04 +0200")
Message-ID: <87bmp0t2lv.fsf@belgarion.home>
User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/24.5 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 808
Lines: 32

Takashi Iwai <tiwai@suse.de> writes:

> On Fri, 30 Jun 2017 21:43:58 +0200,
> Robert Jarzmik wrote:
>> +static struct bus_type ac97_bus_type = {
>> +	.name		= "ac97",
>
> Name-conflict with the old ac97 bus?
Yeah, fair point. So what should I choose for this new one ?
 - ac97new
 - ac97bis
 - ac97_2
 - ac97reborn

>> +static int __init ac97_bus_init(void)
>> +{
>> +	return bus_register(&ac97_bus_type);
>> +}
>> +subsys_initcall(ac97_bus_init);
>> +
>> +MODULE_LICENSE("GPL");
>> +MODULE_AUTHOR("Robert Jarzmik <robert.jarzmik@free.fr>");
>
> No bus_unregister() at exit?
Mmmh, that's because I used subsys_initcall(), which doesn't look good in a
module compilation setup. That will require a module_init(), and I will think
about how to implement it and test it for next iteration.

Cheers.

-- 
Robert