Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752285AbdGDUKd (ORCPT <rfc822;w@1wt.eu>);
        Tue, 4 Jul 2017 16:10:33 -0400
Received: from mx2.suse.de ([195.135.220.15]:46093 "EHLO mx1.suse.de"
        rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP
        id S1752161AbdGDUKb (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 4 Jul 2017 16:10:31 -0400
Date: Tue, 04 Jul 2017 22:10:28 +0200
Message-ID: <s5hbmp0c6a3.wl-tiwai@suse.de>
From: Takashi Iwai <tiwai@suse.de>
To: Robert Jarzmik <robert.jarzmik@free.fr>
Cc: "Dmitry Torokhov" <dmitry.torokhov@gmail.com>,
        "Haojian Zhuang" <haojian.zhuang@gmail.com>,
        "Liam Girdwood" <lgirdwood@gmail.com>,
        "Mark Brown" <broonie@kernel.org>, "Lee Jones" <lee.jones@linaro.org>,
        "Lars-Peter Clausen" <lars@metafoo.de>,
        "Charles Keepax" <ckeepax@opensource.wolfsonmicro.com>,
        "Jaroslav Kysela" <perex@perex.cz>, "Daniel Mack" <daniel@zonque.org>,
        <alsa-devel@alsa-project.org>, <linux-arm-kernel@lists.infradead.org>,
        <patches@opensource.wolfsonmicro.com>, <linux-input@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 02/12] ALSA: ac97: add an ac97 bus
In-Reply-To: <87bmp0t2lv.fsf@belgarion.home>
References: <20170630194408.24978-1-robert.jarzmik@free.fr>
        <20170630194408.24978-3-robert.jarzmik@free.fr>
        <s5hpodhc28v.wl-tiwai@suse.de>
        <87bmp0t2lv.fsf@belgarion.home>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.2
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1198
Lines: 49

On Tue, 04 Jul 2017 21:37:48 +0200,
Robert Jarzmik wrote:
> 
> Takashi Iwai <tiwai@suse.de> writes:
> 
> > On Fri, 30 Jun 2017 21:43:58 +0200,
> > Robert Jarzmik wrote:
> >> +static struct bus_type ac97_bus_type = {
> >> +	.name		= "ac97",
> >
> > Name-conflict with the old ac97 bus?
> Yeah, fair point. So what should I choose for this new one ?
>  - ac97new
>  - ac97bis
>  - ac97_2
>  - ac97reborn

ac97bus
ac97_episode_5
ac98
...

I have no opinion on it.


> >> +static int __init ac97_bus_init(void)
> >> +{
> >> +	return bus_register(&ac97_bus_type);
> >> +}
> >> +subsys_initcall(ac97_bus_init);
> >> +
> >> +MODULE_LICENSE("GPL");
> >> +MODULE_AUTHOR("Robert Jarzmik <robert.jarzmik@free.fr>");
> >
> > No bus_unregister() at exit?
> Mmmh, that's because I used subsys_initcall(), which doesn't look good in a
> module compilation setup. That will require a module_init(), and I will think
> about how to implement it and test it for next iteration.

You can use subsys_init() for modules, it's no problem.
When it's built for a module, all xxx_init() is handled as equivalent
with module_init().  See linux/module.h.

It's just the lack of module_exit() in your case.


thanks,

Takashi