Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752361AbdGDVzb (ORCPT ); Tue, 4 Jul 2017 17:55:31 -0400 Received: from gateway24.websitewelcome.com ([192.185.51.251]:18603 "EHLO gateway24.websitewelcome.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752169AbdGDVza (ORCPT ); Tue, 4 Jul 2017 17:55:30 -0400 Date: Tue, 4 Jul 2017 16:55:26 -0500 From: "Gustavo A. R. Silva" To: Cliff Whickman , Robin Holt Cc: linux-kernel@vger.kernel.org, "Gustavo A. R. Silva" Subject: [PATCH] sgi-xpc: remove unnecessary static in xpc_setup_msg_structures_uv() Message-ID: <20170704215526.GA10933@embeddedgus> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.23 (2014-03-12) X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 189.152.164.199 X-Exim-ID: 1dSVn4-002YXf-TX X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: (embeddedgus) [189.152.164.199]:45460 X-Source-Auth: garsilva@embeddedor.com X-Email-Count: 13 X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1518 Lines: 63 Remove unnecessary static on local variable _ret_. Such variable is initialized before being used, on every execution path throughout the function. The static has no benefit and, removing it reduces the code size. This issue was detected using Coccinelle and the following semantic patch: @bad exists@ position p; identifier x; type T; @@ static T x@p; ... x = <+...x...+> @@ identifier x; expression e; type T; position p != bad.p; @@ -static T x@p; ... when != x when strict ?x = e; In the following log you can see the difference in the code size. This log is the output of the size command, before and after the code change: before: text data bss dec hex filename 25457 3056 448 28961 7121 drivers/misc/sgi-xp/xpc_uv.o after: text data bss dec hex filename 25405 3000 384 28789 7075 drivers/misc/sgi-xp/xpc_uv.o Signed-off-by: Gustavo A. R. Silva --- drivers/misc/sgi-xp/xpc_uv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/misc/sgi-xp/xpc_uv.c b/drivers/misc/sgi-xp/xpc_uv.c index 340b44d..6581eba 100644 --- a/drivers/misc/sgi-xp/xpc_uv.c +++ b/drivers/misc/sgi-xp/xpc_uv.c @@ -1151,7 +1151,7 @@ xpc_allocate_recv_msg_slot_uv(struct xpc_channel *ch) static enum xp_retval xpc_setup_msg_structures_uv(struct xpc_channel *ch) { - static enum xp_retval ret; + enum xp_retval ret; struct xpc_channel_uv *ch_uv = &ch->sn.uv; DBUG_ON(ch->flags & XPC_C_SETUP); -- 2.5.0