Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752303AbdGDWBM (ORCPT ); Tue, 4 Jul 2017 18:01:12 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:57756 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752174AbdGDWBK (ORCPT ); Tue, 4 Jul 2017 18:01:10 -0400 Date: Tue, 04 Jul 2017 23:00:40 +0100 (WEST) Message-Id: <20170704.230040.195111189904913382.davem@davemloft.net> To: elena.reshetova@intel.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-decnet-user@lists.sourceforge.net, jmorris@namei.org, kaber@trash.net, yoshfuji@linux-ipv6.org, kuznet@ms2.inr.ac.ru, 3chas3@gmail.com, ralf@linux-mips.org, stephen@networkplumber.org, jchapman@katalix.com, jhs@mojatatu.com, bridge@lists.linux-foundation.org, linux-hams@vger.kernel.org, linux-x25@vger.kernel.org, peterz@infradead.org, keescook@chromium.org, linux-rdma@vger.kernel.org, linux-sctp@vger.kernel.org, vyasevich@gmail.com, nhorman@tuxdriver.com, linux-nfs@vger.kernel.org, zyan@redhat.com, sage@redhat.com, bfields@fieldses.org, jlayton@poochiereds.net, steffen.klassert@secunet.com, herbert@gondor.apana.org.au, santosh.shilimkar@oracle.com, jreuter@yaina.de Subject: Re: [PATCH 00/36] v2 net subsystem misc refcounter conversions From: David Miller In-Reply-To: <1499172811-16271-1-git-send-email-elena.reshetova@intel.com> References: <1499172811-16271-1-git-send-email-elena.reshetova@intel.com> X-Mailer: Mew version 6.7 on Emacs 25.2 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 04 Jul 2017 15:01:08 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1890 Lines: 39 From: Elena Reshetova Date: Tue, 4 Jul 2017 15:52:55 +0300 > Changes in v2: > * rebase on top of net-next > * currently by default refcount_t = atomic_t (*) and uses all > atomic standard operations unless CONFIG_REFCOUNT_FULL is enabled. > This is a compromise for the systems that are critical on > performance (such as net) and cannot accept even slight delay > on the refcounter operations. > > This series, for various misc network components, replaces atomic_t reference > counters with the new refcount_t type and API (see include/linux/refcount.h). > By doing this we prevent intentional or accidental > underflows or overflows that can led to use-after-free vulnerabilities. > These are the last networking-related conversions with the exception of > network drivers (to be send separately). > > Please excuse the long patch set, but seems like breaking it up > won't save that much on CC list and most of the changes are > trivial. > > The patches are fully independent and can be cherry-picked separately. > In order to try with refcount functionality enabled in run-time, > CONFIG_REFCOUNT_FULL must be enabled. > > NOTE: automatic kernel builder for some reason doesn't like all my > network branches and regularly times out the builds on these branches. > Suggestion for "waiting a day for a good coverage" doesn't work, as > we have seen with generic network conversions. So please wait for the > full report from kernel test rebot before merging further up. > This has been compile-tested in 116 configs, but 71 timed out (including > all s390-related configs again). I am trying to see if they can fix > build coverage for me in meanwhile. > > * The respective change is currently merged into -next as > "locking/refcount: Create unchecked atomic_t implementation". Series applied, that's enough for this cycle, please.