Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753827AbdGDWIm (ORCPT ); Tue, 4 Jul 2017 18:08:42 -0400 Received: from gateway36.websitewelcome.com ([192.185.201.2]:23149 "EHLO gateway36.websitewelcome.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752257AbdGDWIl (ORCPT ); Tue, 4 Jul 2017 18:08:41 -0400 X-Greylist: delayed 1438 seconds by postgrey-1.27 at vger.kernel.org; Tue, 04 Jul 2017 18:08:41 EDT Date: Tue, 4 Jul 2017 16:44:40 -0500 From: "Gustavo A. R. Silva" To: Borislav Petkov , Mauro Carvalho Chehab Cc: linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org, "Gustavo A. R. Silva" Subject: [PATCH] EDAC: remove unnecessary static in edac_fake_inject_write() Message-ID: <20170704214440.GA9462@embeddedgus> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.23 (2014-03-12) X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 189.152.164.199 X-Exim-ID: 1dSVcf-002SBx-6R X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: (embeddedgus) [189.152.164.199]:45378 X-Source-Auth: garsilva@embeddedor.com X-Email-Count: 10 X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1534 Lines: 63 Remove unnecessary static on local variable _type_. Such variable is initialized before being used, on every execution path throughout the function. The static has no benefit and, removing it reduces the code size. This issue was detected using Coccinelle and the following semantic patch: @bad exists@ position p; identifier x; type T; @@ static T x@p; ... x = <+...x...+> @@ identifier x; expression e; type T; position p != bad.p; @@ -static T x@p; ... when != x when strict ?x = e; In the following log you can see the difference in the code size and, also a significant difference in bss segment. This log is the output of the size command, before and after the code change: before: text data bss dec hex filename 2966 920 128 4014 fae drivers/edac/debugfs.o after: text data bss dec hex filename 2961 832 64 3857 f11 drivers/edac/debugfs.o Signed-off-by: Gustavo A. R. Silva --- drivers/edac/debugfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/edac/debugfs.c b/drivers/edac/debugfs.c index 92dbb7e..ba0af49 100644 --- a/drivers/edac/debugfs.c +++ b/drivers/edac/debugfs.c @@ -8,7 +8,7 @@ static ssize_t edac_fake_inject_write(struct file *file, { struct device *dev = file->private_data; struct mem_ctl_info *mci = to_mci(dev); - static enum hw_event_mc_err_type type; + enum hw_event_mc_err_type type; u16 errcount = mci->fake_inject_count; if (!errcount) -- 2.5.0