Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752724AbdGDWQ5 (ORCPT ); Tue, 4 Jul 2017 18:16:57 -0400 Received: from mail-pf0-f173.google.com ([209.85.192.173]:35142 "EHLO mail-pf0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752262AbdGDWQz (ORCPT ); Tue, 4 Jul 2017 18:16:55 -0400 Subject: Re: Commit edf064e7c (btrfs: nowait aio support) breaks shells To: Goldwyn Rodrigues , Markus Trippelsdorf , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-btrfs@vger.kernel.org Cc: David Sterba References: <20170704042306.GA274@x4> <20170704074505.GA277@x4> From: Jens Axboe Message-ID: Date: Tue, 4 Jul 2017 16:16:52 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1192 Lines: 44 On 07/04/2017 09:31 AM, Goldwyn Rodrigues wrote: > > > On 07/04/2017 02:45 AM, Markus Trippelsdorf wrote: >> On 2017.07.04 at 06:23 +0200, Markus Trippelsdorf wrote: >>> commit edf064e7c6fec3646b06c944a8e35d1a3de5c2c3 (HEAD, refs/bisect/bad) >>> Author: Goldwyn Rodrigues >>> Date: Tue Jun 20 07:05:49 2017 -0500 >>> >>> btrfs: nowait aio support >>> >>> apparently breaks several shell related features on my system. >> >> Here is a simple testcase: >> >> % echo "foo" >> test >> % echo "foo" >> test >> % cat test >> foo >> % >> > > Thanks for testing. > Yes, pos must be set with iocb->ki_pos for appends. I should not have > removed the initialization. Could you try this patch? > > diff --git a/fs/btrfs/file.c b/fs/btrfs/file.c > index 59e2dccdf75b..7947781229e5 100644 > --- a/fs/btrfs/file.c > +++ b/fs/btrfs/file.c > @@ -1931,6 +1931,7 @@ static ssize_t btrfs_file_write_iter(struct kiocb > *iocb, > */ > update_time_for_write(inode); > > + pos = iocb->ki_pos; > start_pos = round_down(pos, fs_info->sectorsize); > oldsize = i_size_read(inode); > if (start_pos > oldsize) { Please expedite getting this upstream, asap. -- Jens Axboe