Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752421AbdGEDHi (ORCPT ); Tue, 4 Jul 2017 23:07:38 -0400 Received: from mga09.intel.com ([134.134.136.24]:38524 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752331AbdGEDHh (ORCPT ); Tue, 4 Jul 2017 23:07:37 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.40,310,1496127600"; d="asc'?scan'208";a="120898193" Date: Wed, 5 Jul 2017 11:02:51 +0800 From: "Du, Changbin" To: Jiri Olsa Cc: "Du, Changbin" , jolsa@kernel.org, peterz@infradead.org, mingo@redhat.com, alexander.shishkin@linux.intel.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] perf sort: only insert overhead && overhead_children when no overhead* field given Message-ID: <20170705030251.GA23139@intel.com> References: <1496307801-24134-1-git-send-email-changbin.du@intel.com> <1496377320-6114-1-git-send-email-changbin.du@intel.com> <20170626080626.GA3526@intel.com> <20170629152252.GA1463@krava> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="qMm9M+Fa2AknHoGS" Content-Disposition: inline In-Reply-To: <20170629152252.GA1463@krava> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1541 Lines: 57 --qMm9M+Fa2AknHoGS Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jun 29, 2017 at 05:22:52PM +0200, Jiri Olsa wrote: > > > --- a/tools/perf/util/sort.c > > > +++ b/tools/perf/util/sort.c > > > @@ -2635,6 +2635,9 @@ static char *setup_overhead(char *keys) > > > if (sort__mode =3D=3D SORT_MODE__DIFF) > > > return keys; > > > =20 > > > + if (strstr(keys, "overhead")) > > > + return keys; > > > + >=20 > ah ok, I think it's right.. basically you're forcing > precedence of the -s option over the --children option >=20 > you could have your example working by running: > $ perf report -s overhead,sym --no-children >=20 Thanks for the knowledge. > please state something like: >=20 > /* > * User already stated overhead within -s option, > * do not mangle with that. > */ >=20 I'll add this as comment around the change for v3. > thanks, > jirka --=20 Thanks, Changbin Du --qMm9M+Fa2AknHoGS Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJZXFbbAAoJEAanuZwLnPNUHIMH/1YNVGXVNKPuQdRWz6JXsjUj Tlvwwhyz4UDyY8DtVcY0Xp/UBL2jruf9XFJx3sVn5ktZRBaCJMj7l6j0NZywgUwV yqs0LZA/0zflkq4XezsQpZr7kGFx4jCv5uy5SIyv+8Yik1xpDVT64Quvqr08nsPK VxHA80KDH4ysKR9T4Ad8qoFWv668byrMYx/bDLOMaXpoNCHkHXqGNJjzeLGEYhfO NoiWV4BcketcK46E9rsdQUwHm15WlH/bFg4D+Q48ArJKVo8B7XoZMXg/gtsW242e s/QsPdZM+PWGi5d7YgHTT06amJneoT+qeaD9gEeVGSMk8A2yTVSoRZv88vAwmWA= =u2MA -----END PGP SIGNATURE----- --qMm9M+Fa2AknHoGS--