Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752290AbdGEGup (ORCPT <rfc822;w@1wt.eu>);
        Wed, 5 Jul 2017 02:50:45 -0400
Received: from mail-pf0-f181.google.com ([209.85.192.181]:34879 "EHLO
        mail-pf0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1750796AbdGEGun (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 5 Jul 2017 02:50:43 -0400
Subject: Re: [QUESTION] perf annotate: how do we fix the 'total period'
 feature ?
To: Namhyung Kim <namhyung@kernel.org>
Cc: Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>,
        LKML <linux-kernel@vger.kernel.org>, Jiri Olsa <jolsa@kernel.org>,
        Milian Wolff <milian.wolff@kdab.com>
References: <a7a611a6-1544-ae69-9068-0c65ca6313cf@gmail.com>
 <CAM9d7cjoBNK3bhchz9yKkE2OOE4OBO-J3a8jaGTN7PXHPFZM6Q@mail.gmail.com>
From: Taeung Song <treeze.taeung@gmail.com>
Message-ID: <75f62a2d-a9f2-1d08-926b-a1615ef14f45@gmail.com>
Date: Wed, 5 Jul 2017 15:50:39 +0900
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.1.1
MIME-Version: 1.0
In-Reply-To: <CAM9d7cjoBNK3bhchz9yKkE2OOE4OBO-J3a8jaGTN7PXHPFZM6Q@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 2705
Lines: 85

Hi Namhyung :)

On 07/05/2017 03:07 PM, Namhyung Kim wrote:
> Hi Taeung,
> 
> On Wed, Jul 5, 2017 at 2:47 PM, Taeung Song <treeze.taeung@gmail.com> wrote:
>> Hi,
>>
>> Two problems of perf-annotate were mentioned in recent PATCH reviews
>> by Milian and Namhyung.
>>
>> Currently perf-annotate has a '--show-total-period' option
>> and a 't' key "Toggle total period view" on TUI browser.
> 
> Hmm... I didn't notice it has the option.  I think its name is
> incorrect and should be --show-nr-samples in accordance with perf
> report.
> 
> 

Okey, I got it.

>>
>> However, they actually show the number of samples, not period(Raw number of
>> event count of sample).
>> So it's a different number to the perf report like below.
>>
>> For example,
>>
>>    $ perf report --stdio --show-nr-sample --show-total-period -S hex2u64
>> ...
>> # Overhead       Samples        Period  Command  Shared Object
>> # ........  ............  ............  .......  .............
>> #
>>       3.07%            36      26484668  perf     perf
>>
>>
>>    $ perf annotate  --stdio --show-total-period -s hex2u64
>>   Percent |      Source code & Disassembly of perf for cycles:ppp (36
>> samples)
>> -----------------------------------------------------------------------------
>>           :
>>           :
>>           :
>>           :      Disassembly of section .text:
>>           :
>>           :      000000000053ef9e <hex2u64>:
>>           :      hex2u64():
>>         0 :        53ef9e:       push   %rbp
>>         0 :        53ef9f:       mov    %rsp,%rbp
>>         0 :        53efa2:       sub    $0x30,%rsp
>>         1 :        53efa6:       callq  424810
>> <pthread_attr_setdetachstate@plt+0x10>
>>         0 :        53efab:       mov    %rdi,-0x28(%rbp)
>>         2 :        53efaf:       mov    %rsi,-0x30(%rbp)
>> ...
>>
>> Problems:
>>    1) the total period of perf-annotate is different from perf-report's
>>    2) perf-annotate only shows the first column as 'Percent'
>>       (even though the number of samples for each addr are actually printed)
>>
>> So we need to just rename it ? ('total period' -> 'samples')
>>
>> Or,
>> we should enable perf-annotate to support both features for 'periods' and
>> 'samples' ?
> 
> I think we should support both.  Then you need to change the code to
> save periods when processing samples and show them in the annotate
> IMHO.
> 
> Thanks,
> Namhyung
> 

Currently perf-annotate only count the number of samples for each addr
in __symbol__inc_addr_samples() of util/annotate.c when processing samples.
But it seems to make new functions for 'periods'..

Okey, I got hints of how to fix this problems.
will send the PATCH for them ! :)

Thanks,
Taeung