Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752436AbdGEG7U (ORCPT ); Wed, 5 Jul 2017 02:59:20 -0400 Received: from mail-lf0-f44.google.com ([209.85.215.44]:32879 "EHLO mail-lf0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750867AbdGEG6G (ORCPT ); Wed, 5 Jul 2017 02:58:06 -0400 Date: Wed, 5 Jul 2017 08:58:03 +0200 From: Jens Wiklander To: Arvind Yadav Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH] tee: tee_shm: Constify dma_buf_ops structures. Message-ID: <20170705065801.GB22143@jax> References: <4fa3727c8a72f01b25081162de3e3ada0356c01d.1498911878.git.arvind.yadav.cs@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <4fa3727c8a72f01b25081162de3e3ada0356c01d.1498911878.git.arvind.yadav.cs@gmail.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 656 Lines: 19 On Sat, Jul 01, 2017 at 05:56:06PM +0530, Arvind Yadav wrote: > dma_buf_ops are not supposed to change at runtime. All functions > working with dma_buf_ops provided by work with > const dma_buf_ops. So mark the non-const structs as const. > > File size before: > text data bss dec hex filename > 2026 112 0 2138 85a drivers/tee/tee_shm.o > > File size After adding 'const': > text data bss dec hex filename > 2138 0 0 2138 85a drivers/tee/tee_shm.o > > Signed-off-by: Arvind Yadav Looks good to me, queueing this. Thanks, Jens