Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752681AbdGEIJV (ORCPT ); Wed, 5 Jul 2017 04:09:21 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:36646 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752546AbdGEIJT (ORCPT ); Wed, 5 Jul 2017 04:09:19 -0400 Date: Wed, 05 Jul 2017 09:09:08 +0100 (WEST) Message-Id: <20170705.090908.458530250899642598.davem@davemloft.net> To: colin.king@canonical.com Cc: ast@kernel.org, daniel@iogearbox.net, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH][bpf-next] bpf: add missing break in for the TCP_BPF_SNDCWND_CLAMP case From: David Miller In-Reply-To: <20170704152112.18623-1-colin.king@canonical.com> References: <20170704152112.18623-1-colin.king@canonical.com> X-Mailer: Mew version 6.7 on Emacs 25.2 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 05 Jul 2017 01:09:13 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 587 Lines: 16 From: Colin King Date: Tue, 4 Jul 2017 16:21:12 +0100 > From: Colin Ian King > > There appears to be a missing break in the TCP_BPF_SNDCWND_CLAMP case. > Currently the non-error path where val is greater than zero falls through > to the default case that sets the error return to -EINVAL. Add in > the missing break. > > Detected by CoverityScan, CID#1449376 ("Missing break in switch") > > Fixes: 13bf96411ad2 ("bpf: Adds support for setting sndcwnd clamp") > Signed-off-by: Colin Ian King Applied.