Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752625AbdGEKha (ORCPT ); Wed, 5 Jul 2017 06:37:30 -0400 Received: from mail.gnudd.com ([77.43.112.34]:57905 "EHLO mail.gnudd.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750841AbdGEKh2 (ORCPT ); Wed, 5 Jul 2017 06:37:28 -0400 X-Greylist: delayed 605 seconds by postgrey-1.27 at vger.kernel.org; Wed, 05 Jul 2017 06:37:28 EDT Date: Wed, 5 Jul 2017 12:27:13 +0200 From: Alessandro Rubini To: riehecky@fnal.gov Cc: linux-kernel@vger.kernel.org, drivers_other@kernel-bugs.osdl.org, gregkh@linuxfoundation.org, federico.vaga@cern.ch Subject: Re: [PATCH 0/5] Update kernel to latest FMC bus release Message-ID: <20170705102713.GA20907@mail.gnudd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Organization: GnuDD, Device Drivers, Embedded Systems, Courses In-Reply-To: References: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 810 Lines: 22 Hello. Thank you Pat for taking care of these patches. > Federico Vaga (5): > drivers/fmc: remove unused variable > drivers/fmc: hide fmc operations behind helpers > drivers/fmc: The only way to dump the SDB is from debugfs > drivers/fmc: change registration prototype > drivers/fmc: carrier can program FPGA on registration The main problem with your patches, as submitted, is that they miss the "From:" line to attribute Federico as author. Then I think you might add your own "Tested-by:". I want to ack them but I'd love to run them first to have a second check. I should definitely manage it in a pair of days more. Meanwhile, if you want to post V2 with the fixes above that would be great. If needed, you can write me offlist. thankyou for your submission and your patience /alessandro