Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751685AbdGENix (ORCPT ); Wed, 5 Jul 2017 09:38:53 -0400 Received: from metis.ext.4.pengutronix.de ([92.198.50.35]:58783 "EHLO metis.ext.4.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751545AbdGENiw (ORCPT ); Wed, 5 Jul 2017 09:38:52 -0400 Date: Wed, 5 Jul 2017 15:38:45 +0200 From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= To: Romain Perier Cc: Greg Kroah-Hartman , linux-serial@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Nandor Han , Clemens Gruber , Fabio Estevam Subject: Re: [PATCH v2 3/6] serial: imx: remove CTSC and CTS handling Message-ID: <20170705133845.32ov37meqcea3wtz@pengutronix.de> References: <20170705130706.10388-1-romain.perier@collabora.com> <20170705130706.10388-4-romain.perier@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20170705130706.10388-4-romain.perier@collabora.com> User-Agent: NeoMutt/20170113 (1.7.2) X-SA-Exim-Connect-IP: 2001:67c:670:100:5054:ff:fe2a:3aa X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1590 Lines: 53 Cc += Clemens Gruber + Fabio Estevam On Wed, Jul 05, 2017 at 03:07:03PM +0200, Romain Perier wrote: > From: Nandor Han > > CTSC and CTS are not related to DMA and might add > disruption in some cases. > > Signed-off-by: Romain Perier If it was Nandor Han who created this patch, it would be great to get his sob. If it was you, drop the From: line above. > --- > drivers/tty/serial/imx.c | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/drivers/tty/serial/imx.c b/drivers/tty/serial/imx.c > index 5291b86..dd3ebb4 100644 > --- a/drivers/tty/serial/imx.c > +++ b/drivers/tty/serial/imx.c > @@ -1249,11 +1249,6 @@ static void imx_disable_dma(struct imx_port *sport) > imx_stop_rx_dma(sport); > imx_stop_tx_dma(sport); > > - /* clear UCR2 */ > - temp = readl(sport->port.membase + UCR2); > - temp &= ~(UCR2_CTSC | UCR2_CTS | UCR2_ATEN); > - writel(temp, sport->port.membase + UCR2); > - Before this patch imx_disable_dma resulted in the #CTS pin being high (inactive). Does this qualify as a fix? If so, you should sort this patch to the beginning of the series. Did you do test this patch and its effects separately? @Clemens: maybe this patch makes a relevant difference when the port is operated in rs485 mode. Do you care to test? > imx_setup_ufcr(sport, TXTL_DEFAULT, RXTL_DEFAULT); > > sport->dma_is_enabled = 0; > -- > 1.8.3.1 Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-K?nig | Industrial Linux Solutions | http://www.pengutronix.de/ |