Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751915AbdGEQDV (ORCPT ); Wed, 5 Jul 2017 12:03:21 -0400 Received: from foss.arm.com ([217.140.101.70]:57848 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751681AbdGEQDT (ORCPT ); Wed, 5 Jul 2017 12:03:19 -0400 Subject: Re: [PATCH] bus: arm-cci: constify attribute_group structures. To: Arvind Yadav , nico@linaro.org, mark.rutland@arm.com, mingo@kernel.org, lorenzo.pieralisi@arm.com References: Cc: linux-kernel@vger.kernel.org From: Suzuki K Poulose Message-ID: <9b105274-212e-1ec1-8b9e-6dd3d6c16484@arm.com> Date: Wed, 5 Jul 2017 17:03:11 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1354 Lines: 44 On 03/07/17 08:46, Arvind Yadav wrote: > attribute_groups are not supposed to change at runtime. All functions > working with attribute_groups provided by work with const > attribute_group. So mark the non-const structs as const. > > Signed-off-by: Arvind Yadav > --- > drivers/bus/arm-cci.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/bus/arm-cci.c b/drivers/bus/arm-cci.c > index c49da15..64c75d2 100644 > --- a/drivers/bus/arm-cci.c > +++ b/drivers/bus/arm-cci.c > @@ -1445,16 +1445,16 @@ static ssize_t pmu_cpumask_attr_show(struct device *dev, > NULL, > }; > > -static struct attribute_group pmu_attr_group = { > +static const struct attribute_group pmu_attr_group = { > .attrs = pmu_attrs, > }; > > -static struct attribute_group pmu_format_attr_group = { > +static const struct attribute_group pmu_format_attr_group = { > .name = "format", > .attrs = NULL, /* Filled in cci_pmu_init_attrs */ > }; > > -static struct attribute_group pmu_event_attr_group = { > +static const struct attribute_group pmu_event_attr_group = { > .name = "events", > .attrs = NULL, /* Filled in cci_pmu_init_attrs */ > }; > I think we cannot make these const, as the attrs field gets filled in at runtime, indicated by the comments next to them. Cheers Suzuki