Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752134AbdGESPh (ORCPT ); Wed, 5 Jul 2017 14:15:37 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33844 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751692AbdGESPf (ORCPT ); Wed, 5 Jul 2017 14:15:35 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 70C3D916CA Authentication-Results: ext-mx05.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx05.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=mchristi@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 70C3D916CA Subject: Re: [PATCH] target: make device_mutex and device_list static To: Colin King , "Nicholas A . Bellinger" , linux-scsi@vger.kernel.org, target-devel@vger.kernel.org References: <20170704084419.10800-1-colin.king@canonical.com> Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org From: Mike Christie Message-ID: <595D2CC4.3090303@redhat.com> Date: Wed, 5 Jul 2017 13:15:32 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <20170704084419.10800-1-colin.king@canonical.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Wed, 05 Jul 2017 18:15:34 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1103 Lines: 35 On 07/04/2017 03:44 AM, Colin King wrote: > From: Colin Ian King > > Variables device_mutex and device_list static are local to the source, > so make them static. > > Cleans up sparse warnings: > "symbol 'device_list' was not declared. Should it be static?" > "symbol 'device_mutex' was not declared. Should it be static?" > > Signed-off-by: Colin Ian King > --- > drivers/target/target_core_device.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/target/target_core_device.c b/drivers/target/target_core_device.c > index 3ae8fbf01bdf..bbcef3bc66c8 100644 > --- a/drivers/target/target_core_device.c > +++ b/drivers/target/target_core_device.c > @@ -49,8 +49,8 @@ > #include "target_core_pr.h" > #include "target_core_ua.h" > > -DEFINE_MUTEX(device_mutex); > -LIST_HEAD(device_list); > +static DEFINE_MUTEX(device_mutex); > +static LIST_HEAD(device_list); > static DEFINE_IDR(devices_idr); > > static struct se_hba *lun0_hba; > My fault. Thanks. Reviewed-by: Mike Christie