Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752058AbdGESrU (ORCPT ); Wed, 5 Jul 2017 14:47:20 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:39836 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751659AbdGESrT (ORCPT ); Wed, 5 Jul 2017 14:47:19 -0400 Date: Wed, 5 Jul 2017 20:47:18 +0200 From: Greg KH To: Todd Kjos Cc: Todd Kjos , Arve =?iso-8859-1?B?SGr4bm5lduVn?= , devel@driverdev.osuosl.org, LKML , Martijn Coenen Subject: Re: [PATCH 01/37] Revert "android: binder: Sanity check at binder ioctl" Message-ID: <20170705184718.GC22044@kroah.com> References: <20170629190211.16927-1-tkjos@google.com> <20170629190211.16927-2-tkjos@google.com> <20170703091707.GB30284@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.8.3 (2017-05-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 653 Lines: 16 On Wed, Jul 05, 2017 at 09:08:48AM -0700, Todd Kjos wrote: > It is reverted here because if we keep it, it would need to be refactored as > part of this patchset since vma_vm_mm is no longer in struct binder_proc (moved > to binder_alloc). The patch introduces a race condition in the driver and an > attempt to fix it was submitted in "[PATCH v2] android: binder: fix dangling > pointer comparison" and the conclusion then was to revert this patch. After > discussing with Arve we decided reverting now was better than refactoring it to > work with FGL. > > Do you want me to add rationale to the commit message? Yes, please do :) thanks, greg k-h