Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752346AbdGESu1 (ORCPT ); Wed, 5 Jul 2017 14:50:27 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:40562 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751772AbdGESu0 (ORCPT ); Wed, 5 Jul 2017 14:50:26 -0400 Date: Wed, 5 Jul 2017 20:50:24 +0200 From: Greg Kroah-Hartman To: David Howells Cc: viro@zeniv.linux.org.uk, reiserfs-devel@vger.kernel.org, Steven Rostedt , linux-kernel@vger.kernel.org, Chris Mason , linux-fsdevel@vger.kernel.org, linux-btrfs@vger.kernel.org Subject: Re: [PATCH 01/14] VFS: Don't use save/replace_mount_options if not using generic_show_options Message-ID: <20170705185024.GE22044@kroah.com> References: <149926824154.20611.6104595541055328700.stgit@warthog.procyon.org.uk> <149926824918.20611.721200514474820755.stgit@warthog.procyon.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <149926824918.20611.721200514474820755.stgit@warthog.procyon.org.uk> User-Agent: Mutt/1.8.3 (2017-05-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 874 Lines: 19 On Wed, Jul 05, 2017 at 04:24:09PM +0100, David Howells wrote: > btrfs, debugfs, reiserfs and tracefs call save_mount_options() and reiserfs > calls replace_mount_options(), but they then implement their own > ->show_options() methods and don't touch s_options, rendering the saved > options unnecessary. I'm trying to eliminate s_options to make it easier > to implement a context-based mount where the mount options can be passed > individually over a file descriptor. > > Remove the calls to save/replace_mount_options() call in these cases. > > Signed-off-by: David Howells > cc: Chris Mason > cc: Greg Kroah-Hartman > cc: Steven Rostedt > cc: linux-btrfs@vger.kernel.org > cc: reiserfs-devel@vger.kernel.org For debugfs: Acked-by: Greg Kroah-Hartman