Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752371AbdGESyv (ORCPT ); Wed, 5 Jul 2017 14:54:51 -0400 Received: from mail.kernel.org ([198.145.29.99]:42496 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752068AbdGESyt (ORCPT ); Wed, 5 Jul 2017 14:54:49 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BA8B0214D7 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=goodmis.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=rostedt@goodmis.org Date: Wed, 5 Jul 2017 14:54:46 -0400 From: Steven Rostedt To: David Howells Cc: viro@zeniv.linux.org.uk, Greg Kroah-Hartman , reiserfs-devel@vger.kernel.org, linux-kernel@vger.kernel.org, Chris Mason , linux-fsdevel@vger.kernel.org, linux-btrfs@vger.kernel.org Subject: Re: [PATCH 01/14] VFS: Don't use save/replace_mount_options if not using generic_show_options Message-ID: <20170705145446.69fa3248@gandalf.local.home> In-Reply-To: <21063.1499268809@warthog.procyon.org.uk> References: <20170705113023.4dbbc3a6@gandalf.local.home> <149926824154.20611.6104595541055328700.stgit@warthog.procyon.org.uk> <149926824918.20611.721200514474820755.stgit@warthog.procyon.org.uk> <21063.1499268809@warthog.procyon.org.uk> X-Mailer: Claws Mail 3.14.0 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 670 Lines: 19 On Wed, 05 Jul 2017 16:33:29 +0100 David Howells wrote: > Steven Rostedt wrote: > > > As this is patch 1/14, is there any dependency on this working? That > > is, it is safe to simply remove this caller from those locations? Or > > are there dependencies on having any of the 2-14 patches added to make > > it not cause issues? > > Patch 14 removes the then-unused helpers, but patches 1-13 otherwise are > independent of each other and have no dependencies on earlier patches. > So basically it's an useless function call wrt tracefs. In that case... Acked-by: Steven Rostedt (VMware) -- Steve