Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752155AbdGETmV (ORCPT ); Wed, 5 Jul 2017 15:42:21 -0400 Received: from mail.kernel.org ([198.145.29.99]:46868 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751783AbdGETmU (ORCPT ); Wed, 5 Jul 2017 15:42:20 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 918E122B54 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=helgaas@kernel.org Date: Wed, 5 Jul 2017 14:42:16 -0500 From: Bjorn Helgaas To: Logan Gunthorpe Cc: linux-ntb@googlegroups.com, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Jon Mason , Dave Jiang , Allen Hubbe , Bjorn Helgaas , Greg Kroah-Hartman , Kurt Schwemmer , Stephen Bates , Serge Semin Subject: Re: [PATCH 13/16] switchtec_ntb: implement doorbell registers Message-ID: <20170705194216.GB25063@bhelgaas-glaptop.roam.corp.google.com> References: <20170629032648.3073-1-logang@deltatee.com> <20170629032648.3073-14-logang@deltatee.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170629032648.3073-14-logang@deltatee.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 448 Lines: 8 On Wed, Jun 28, 2017 at 09:26:45PM -0600, Logan Gunthorpe wrote: > Pretty straightforward implementation of doorbell registers. > The shift and mask were setup in an earlier patch and this just hooks > up the approprirate portion of the idb register as the local doorbells > and the opposite portion of odb as the peer doorbells. The db mask is > protected by a spinlock to avoid concurrent read-modify-write accesses. s/approprirate/appropriate/