Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755677AbdGEULV (ORCPT ); Wed, 5 Jul 2017 16:11:21 -0400 Received: from mail-pg0-f52.google.com ([74.125.83.52]:36576 "EHLO mail-pg0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753182AbdGEULS (ORCPT ); Wed, 5 Jul 2017 16:11:18 -0400 Date: Wed, 5 Jul 2017 13:11:04 -0700 From: Benson Leung To: Lee Jones Cc: Thierry Escande , Benson Leung , linux-kernel@vger.kernel.org, enric.balletbo@collabora.com, bleung@google.com Subject: Re: [PATCH v2 3/3] cros_ec: Don't signal wake event for non-wake host events Message-ID: <20170705201104.GC77970@decatoncale.mtv.corp.google.com> References: <1487102282-12259-1-git-send-email-thierry.escande@collabora.com> <1487102282-12259-4-git-send-email-thierry.escande@collabora.com> <20170627162353.GC39605@decatoncale.mtv.corp.google.com> <20170703114641.2zivoeqiv7tk4bqu@dell> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="O3RTKUHj+75w1tg5" Content-Disposition: inline In-Reply-To: <20170703114641.2zivoeqiv7tk4bqu@dell> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2814 Lines: 83 --O3RTKUHj+75w1tg5 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Lee, On Mon, Jul 03, 2017 at 12:46:41PM +0100, Lee Jones wrote: > On Tue, 27 Jun 2017, Benson Leung wrote: >=20 > > Hi Thierry, > >=20 > > On Tue, Feb 14, 2017 at 08:58:02PM +0100, Thierry Escande wrote: > > > From: Shawn Nematbakhsh > > >=20 > > > The subset of wake-enabled host events is defined by the EC, but the = EC > > > may still send non-wake host events if we're in the process of > > > suspending. Get the mask of wake-enabled host events from the EC and > > > filter out non-wake events to prevent spurious aborted suspend > > > attempts. > > >=20 > > > Signed-off-by: Shawn Nematbakhsh > > > Signed-off-by: Thierry Escande > > > --- > > > drivers/mfd/cros_ec.c | 13 ++++-- > > > drivers/platform/chrome/cros_ec_proto.c | 76 +++++++++++++++++++++++= +++++++--- > > > include/linux/mfd/cros_ec.h | 5 ++- > > > 3 files changed, 85 insertions(+), 9 deletions(-) > > >=20 > >=20 > > Another use of cros_ec_get_next_event was introduced in cros_ec_lpc.c s= ince > > this patch was posted, so I went ahead and modified that too. > >=20 > > Applied. Thanks. >=20 > No need to change anything this time, but please note the "for my own > reference" in my Ack in future. It typically means that I plan on > pushing it through the MFD tree or that it requires further discussion > (in the case that another Maintainer would prefer it go through their > tree). >=20 Sorry about that. Thanks for the advice! I'm still getting my sea legs for maintainership. Benson --=20 Benson Leung Staff Software Engineer Chrome OS Kernel Google Inc. bleung@google.com Chromium OS Project bleung@chromium.org --O3RTKUHj+75w1tg5 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBCgAGBQJZXUfYAAoJEB8J9XsKL+ZYXHoQAKOkU7FeqH2cpIUzuA1qiwPO spSCEFiGkvk1g4vs4ClJ399nuMLUcXHMU16Oql77cyMzj666JagUVzPpC4ji2dXX M5d/L0bBq06p7KBKhoqNCmRqJ+Vu6uXfq3A8UM6rNKTN5uAuonb/pTsagerQTuZC lkBqQwHJeRijJXGAiEgJuCnKyuTXat45napnLJ1OIjflZcACLj37ZwnSiH2qjHQy d4L0bG3GRsre02FHVzVLc/jtEFjDkOihuTM3yA89rLyHPWghHaXi8cPbuxCi9nAP 5JQw880SdxsFQ/vCvcw08eAEJZQ7OVQRJZ5NUoWibtThhnxDe3/tF6SGrLAtQPzo abz3uGBytJ5Yc3mFtcaExiJlarObPLN4eoD09efOo4SdlmXkz5Zxtv04cXY6K53M UNr2Lo8YLTdhmw0fj9gudUbL9iCCtxT2NKzo7gNqITpWijB5URD5trFK4EXH1eQT KVAVpzyUW9N1gBcSlvDJEYFTXXCCKANGWpU8SMuGfKNX0uDJwbrgesEgBiNDNGN1 yJmtN/MSR1CQD9pVJ75V7hSp+33QSeMnwuzbVMJZuRyGOY2bF9etbgaFh3q8chGg id2y5BpqfkCJdi+mq8R1fhOXEu+vq1ziYEouRaia3TNnk48+1fSr8HEsIlV0Flit yvNPEWuV6dfWYKdGqoli =FL6n -----END PGP SIGNATURE----- --O3RTKUHj+75w1tg5--