Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753321AbdGEUjt (ORCPT ); Wed, 5 Jul 2017 16:39:49 -0400 Received: from smtp2-g21.free.fr ([212.27.42.2]:58274 "EHLO smtp2-g21.free.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752040AbdGEUjq (ORCPT ); Wed, 5 Jul 2017 16:39:46 -0400 Subject: Re: [PATCH v9 0/3] Tango PCIe controller support To: Bjorn Helgaas Cc: Marc Gonzalez , Marc Zyngier , Thomas Gleixner , linux-pci , Linux ARM , LKML , DT , Thibaud Cornic References: <987fac41-80dc-f1d0-ec0b-91ae57b91bfd@sigmadesigns.com> <20170704202412.GK13824@bhelgaas-glaptop.roam.corp.google.com> <6256cab3-dd77-c0f6-66b8-be261695bbb1@free.fr> <20170705180359.GL13824@bhelgaas-glaptop.roam.corp.google.com> From: Mason Message-ID: <5a1207cb-31fd-6b85-86af-8c37bd57ad4f@free.fr> Date: Wed, 5 Jul 2017 22:39:19 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:52.0) Gecko/20100101 Firefox/52.0 SeaMonkey/2.49.1 MIME-Version: 1.0 In-Reply-To: <20170705180359.GL13824@bhelgaas-glaptop.roam.corp.google.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2621 Lines: 85 On 05/07/2017 20:03, Bjorn Helgaas wrote: > On Wed, Jul 05, 2017 at 12:55:37AM +0200, Mason wrote: > >> On 04/07/2017 22:24, Bjorn Helgaas wrote: >> >>> I made the trivial changes I mentioned, added a dependency on >>> CONFIG_BROKEN (for the config/MMIO muxing issue), and put these on >>> pci/host-tango. I can't build or test this, so I probably broke >>> something in the process. I think the combination of the boot-time >>> warning, the taint, and CONFIG_BROKEN is a reasonable amount of >>> warning that a user should expect issues. >>> >>> Can you take a look and see if it works for you? >>> >>> https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git/log/?h=pci/host-tango >> >> Thanks. I'll take it for a spin ASAP. >> >> TAINT_CRAP... Smirk. I didn't see that one in the docs: >> https://www.kernel.org/doc/html/latest/admin-guide/tainted-kernels.html >> >> Oh wait... TAINT_CRAP is "C" => a staging driver has been loaded > > I wish it had a less pejorative, more descriptive name. But it seems like > the closest to this situation. Maybe it is not too late to submit a patch to Linus renaming TAINT_CRAP? Here are a few candidates, off the top of my head: TAINT_STAGING TAINT_STAGING_DRIVER TAINT_BROKEN_HW TAINT_BROKEN_HARDWARE TAINT_USE_AT_YOUR_OWN_RISK >> The one issue I anticipate with "depends on BROKEN" is >> when I add support for revision 2, which isn't broken. > > How about this: > > - Rename PCIE_TANGO to PCIE_TANGO_REV1 > - PCIE_TANGO_REV1 depends on BROKEN > - Add rev2 support later, enabled by PCIE_TANGO > - PCIE_TANGO_REV1 depends on PCIE_TANGO && BROKEN > > I updated pci/host-tango along these lines (without rev2 support, > obviously). And support for REV1 wouldn't be compiled in, unless BROKEN is selected? Yes, I think that could fly. Don't you think the naming should follow the DT convention of using the first SoC embedding the IP (for the compatible string) ? PCIE_TANGO_REV1 vs PCIE_TANGO_SMP8759 > I forgot to ask for a MAINTAINERS update. Can you send that, too, > please? There's a "catch-all" rule for everything tango-related: ARM/TANGO ARCHITECTURE M: Marc Gonzalez L: linux-arm-kernel@lists.infradead.org S: Maintained N: tango Is that enough? > Which reminds me -- are these two addreses > > Marc Gonzalez > Mason > > different names for the same person? Conversations are easier for me > if I can keep who's who straight :) Well, there are many voices inside my head, but yes, respectively professional and personal addresses. Regards.