Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752399AbdGEVP2 (ORCPT ); Wed, 5 Jul 2017 17:15:28 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:39456 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751659AbdGEVP0 (ORCPT ); Wed, 5 Jul 2017 17:15:26 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 0B427607E0 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=sboyd@codeaurora.org Date: Wed, 5 Jul 2017 14:15:18 -0700 From: Stephen Boyd To: Vincent Legoll Cc: linux-kernel@vger.kernel.org, mturquette@baylibre.com, linux-clk@vger.kernel.org Subject: Re: [PATCH] Make Common clock framework a menuconfig to ease disabling it all Message-ID: <20170705211518.GU22780@codeaurora.org> References: <1499011768-8046-1-git-send-email-vincent.legoll@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1499011768-8046-1-git-send-email-vincent.legoll@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 898 Lines: 26 On 07/02, Vincent Legoll wrote: > No need to get into the submenu to disable all common clock framework > -related config entries > > Signed-off-by: Vincent Legoll > --- > diff --git a/drivers/clk/Kconfig b/drivers/clk/Kconfig > index 36cfea3..a1b174c 100644 > --- a/drivers/clk/Kconfig > +++ b/drivers/clk/Kconfig > @@ -19,9 +19,12 @@ config COMMON_CLK > Architectures utilizing the common struct clk should select > this option. > > -menu "Common Clock Framework" > +menuconfig COMMON_CLK_FRAMEWORK > + tristate "Common Clock Framework" > depends on COMMON_CLK Wouldn't this put the clk drivers inside the drivers menu? Which is already quite large right now. Plus this makes common clk tristate which so far we haven't supported. No thanks. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project