Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752467AbdGEXzT (ORCPT ); Wed, 5 Jul 2017 19:55:19 -0400 Received: from mail-oi0-f41.google.com ([209.85.218.41]:35221 "EHLO mail-oi0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751896AbdGEXzS (ORCPT ); Wed, 5 Jul 2017 19:55:18 -0400 MIME-Version: 1.0 In-Reply-To: References: <1499126133.2707.20.camel@decadent.org.uk> <20170704084122.GC14722@dhcp22.suse.cz> <20170704093538.GF14722@dhcp22.suse.cz> <20170704094728.GB22013@1wt.eu> <20170704104211.GG14722@dhcp22.suse.cz> <20170704113611.GA4732@decadent.org.uk> <1499209315.2707.29.camel@decadent.org.uk> <1499257180.2707.34.camel@decadent.org.uk> <20170705142354.GB21220@dhcp22.suse.cz> From: Linus Torvalds Date: Wed, 5 Jul 2017 16:55:16 -0700 X-Google-Sender-Auth: HdnKA8wnbP0xVq2pT-_fRv74fR8 Message-ID: Subject: Re: [PATCH] mm: larger stack guard gap, between vmas To: Kees Cook Cc: Andy Lutomirski , Michal Hocko , Ben Hutchings , Willy Tarreau , Hugh Dickins , Oleg Nesterov , "Jason A. Donenfeld" , Rik van Riel , Larry Woodman , "Kirill A. Shutemov" , Tony Luck , "James E.J. Bottomley" , Helge Diller , James Hogan , Laura Abbott , Greg KH , "security@kernel.org" , Qualys Security Advisory , LKML , Ximin Luo Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 414 Lines: 13 On Wed, Jul 5, 2017 at 4:50 PM, Kees Cook wrote: > > As part of that should we put restrictions on the environment of > set*id exec too? I'm not seeing what sane limits you could use. I think the concept of "reset as much of the environment to sane things when running suid binaries" is a good concepr. But we simply don't have any sane values to reset things to. Linus