Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752681AbdGFBCq (ORCPT ); Wed, 5 Jul 2017 21:02:46 -0400 Received: from mail-pf0-f195.google.com ([209.85.192.195]:33327 "EHLO mail-pf0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752440AbdGFBCo (ORCPT ); Wed, 5 Jul 2017 21:02:44 -0400 MIME-Version: 1.0 In-Reply-To: <20170705124734.12816-1-colin.king@canonical.com> References: <20170705124734.12816-1-colin.king@canonical.com> From: Steve French Date: Wed, 5 Jul 2017 20:02:22 -0500 Message-ID: Subject: Re: [PATCH][cifs-next] cifs: set oparms.create_options rather than or'ing in CREATE_OPEN_BACKUP_INTENT To: Colin King Cc: Steve French , "linux-cifs@vger.kernel.org" , samba-technical , kernel-janitors , LKML Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1373 Lines: 44 good catch - merged into cifs-2.6.git for-next On Wed, Jul 5, 2017 at 7:47 AM, Colin King wrote: > From: Colin Ian King > > Currently oparms.create_options is uninitialized and the code is logically > or'ing in CREATE_OPEN_BACKUP_INTENT onto a garbage value of > oparms.create_options from the stack. Fix this by just setting the value > rather than or'ing in the setting. > > Detected by CoverityScan, CID#1447220 ("Unitialized scale value") > > Signed-off-by: Colin Ian King > --- > fs/cifs/smb2ops.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/cifs/smb2ops.c b/fs/cifs/smb2ops.c > index 941c40b7a870..c805b7619083 100644 > --- a/fs/cifs/smb2ops.c > +++ b/fs/cifs/smb2ops.c > @@ -1339,7 +1339,7 @@ get_smb2_acl_by_path(struct cifs_sb_info *cifs_sb, > xid = get_xid(); > > if (backup_cred(cifs_sb)) > - oparms.create_options |= CREATE_OPEN_BACKUP_INTENT; > + oparms.create_options = CREATE_OPEN_BACKUP_INTENT; > else > oparms.create_options = 0; > > -- > 2.11.0 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-cifs" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Thanks, Steve