Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752654AbdGFBjw convert rfc822-to-8bit (ORCPT ); Wed, 5 Jul 2017 21:39:52 -0400 Received: from mailout3.samsung.com ([203.254.224.33]:21869 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752479AbdGFBju (ORCPT ); Wed, 5 Jul 2017 21:39:50 -0400 X-AuditID: b6c32a35-f794c6d000001ab7-89-595d94e4e439 Mime-Version: 1.0 Subject: RE: Re: [PATCH] PM / devfreq: constify attribute_group structures. Reply-To: myungjoo.ham@samsung.com From: MyungJoo Ham To: Chanwoo Choi , Arvind Yadav , Kyungmin Park CC: "linux-pm@vger.kernel.org" , "linux-kernel@vger.kernel.org" X-Priority: 3 X-Content-Kind-Code: NORMAL In-Reply-To: <595A19AA.3060105@samsung.com> X-Drm-Type: N,general X-EPLocale: ko_KR.EUC-KR X-EPWebmail-Msg-Type: personal X-Msg-Generator: Mail X-Msg-Type: PERSONAL X-Reply-Demand: N Illegal-Object: Syntax error in X-Sender: address found on vger.kernel.org: X-Sender: =?utf-8?B?U2Ftc3VuZyBFbGVjdHJvbmljcxtGcm9udGll?= ^-Extraneous program text X-Sender-IP: 10.113.73.204 X-Local-Sender: =?UTF-8?B?7ZWo66qF7KO8G0Zyb250aWVyIENTIExhYihTL1fshLzthLApG+yCvOyEsQ==?= =?UTF-8?B?7KCE7J6QG1ByaW5jaXBhbCBFbmdpbmVlcg==?= X-Global-Sender: =?UTF-8?B?TXl1bmdKb28gSGFtG0Zyb250aWVyIENTIExhYi4bU2Ftc3VuZyBFbGVj?= =?UTF-8?B?dHJvbmljcxtQcmluY2lwYWwgRW5naW5lZXI=?= X-Sender-Code: =?UTF-8?B?QzEwGxtDMTBWODEwNA==?= Message-ID: <20170706013947epcms1p3be4b0f009cb73ccf8d555c9e6d1c529d@epcms1p3> Date: Thu, 06 Jul 2017 01:39:47 +0000 X-CMS-MailID: 20170706013947epcms1p3be4b0f009cb73ccf8d555c9e6d1c529d Content-Transfer-Encoding: 8BIT Content-Type: text/plain; charset="utf-8" X-MTR: 20170706013947epcms1p3be4b0f009cb73ccf8d555c9e6d1c529d CMS-TYPE: 101P X-Brightmail-Tracker: H4sIAAAAAAAAA02SfUhTYRTGeb3e7Sreuk1dJ4Ww2wdMc9td25rRKmiUoZLQH2Um6+IuU3If 7c6+CLIkNMs+VvYxpRLDSIWFuLQFBTMKJE3KFCPFhTlJsw+TMLLavJP673mf93fOwzkcApPM 4klEsdXJOaxsCS2KjX7QKZOnj14pyFMGBuN0/dX1mG7gexDXdZ+aFOte++pEuunqp2gLnvnQ PSTOPN/WhDKnW5fnYnu5jUUca+IcKZy10GYqtpr1dNYu41ajRqtk0pkM3Xo6xcpaOD1tyM5N 31ZcEoqkUw6xJaUhK5fleVqxaaPDVurkUopsvFNP5zOMSs4o18tVKpVcva5gg0oTQvZzRcPB cbH9CXnkZu0UKkMXyCoUQwClhhsDH6IFLYXeYY+oCsUSEqoDwdcyd+iDIEhqCcx1xIeZeCoL TlaNicJaQtFQNvgYE3wFVI48QGEtotLBe39ovmcCdQJ+tnjFYY1Rx+DXvRGRkEXC9YqF3GRo v+udr42h0qAi+BYJfiIMNn8SCxrg3URvlKCXw9WZFmyB+fzsVoRPgNPD3RF/CYzMPor4B8HT MBvJSoK3Df1R4RmBOovg+p3nuPCoRNDz60ckQQFPXIH5CpLKgfaalpAWE9HUahg7LhAG8He5 InOlQWP9BBZeFUbJwONTCIgefBd9SEAWwdTMOVzw14D/0R3xRbTK/W+57v8auf81uo2wJiTl 7LzFzPGMnZHzrIUvtZrlhTZLK5o/u1RNB7rSk+1HFIHoOLJyal+eBGcP8UctfgQERieQzOWC PAlpYo8e4xw2o6O0hOP9SBOa5hKWlFhoCx2x1Wlk1BlKtVYVOrgMhqGXkome/j0Sysw6uQMc Z+ccC3VRRExSGdr2/pWB2LF3t/vxG6mzr2YuaNC5Ts0kd2Z965rEc2S9rdurAycSc3Y2n2bd o30V+WLtlt+mL9tr8BeDPUqzR31tyPKtzdope8NKB7Qr+sYOK+oaa5dtkH1M9bkO/Fm7SR+7 uVzqnSsPvFzsW9mFjxdqu7P0Z/YP4C7zjau6Xj8dzRexTCrm4Nm/7vADwIwDAAA= DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20170703101025epcas4p151a0c496ae3410031c27f4da7ab9714f X-RootMTR: 20170703101025epcas4p151a0c496ae3410031c27f4da7ab9714f References: <595A19AA.3060105@samsung.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1091 Lines: 64 > On 2017년 07월 03일 19:10, Arvind Yadav wrote: > > attribute_groups are not supposed to change at runtime. All functions > > working with attribute_groups provided by work with const > > attribute_group. So mark the non-const structs as const. > > > > File size before: > > text data bss dec hex filename > > 621 176 0 797 31d drivers/devfreq/governor_userspace.o > > > > File size After adding 'const': > > text data bss dec hex filename > > 670 144 0 814 32e drivers/devfreq/governor_userspace.o > > > > Signed-off-by: Arvind Yadav > > --- > > drivers/devfreq/governor_userspace.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/devfreq/governor_userspace.c b/drivers/devfreq/governor_userspace.c [] > > Looks good to me. > Reviewed-by: Chanwoo Choi Acked-by: MyungJoo Ham Thank you. Applying to for-rc branch. Cheers, MyungJoo