MIME-Version: 1.0
Reply-To: robert@ocallahan.org
In-Reply-To: <20170704102159.GB20062@leverpostej>
References: <CAP045Ao2=6A7GEhBfmY0gZ2g=urL5U4R5ywLsTo4Yb6Tk1M8Cw@mail.gmail.com>
 <2256f9b5-1277-c4b1-1472-61a10cd1db9a@linux.intel.com> <CAP045AryPCUTO92S3hmrkag3D7NqgJM-hK82a7iKm9s-rWdn1w@mail.gmail.com>
 <20170628101248.GB5981@leverpostej> <20170628105600.GC5981@leverpostej>
 <CAP045ApjOeng6M9kqwbNpv5OTN=_Gkk2MHREztzZV_CecqpmxQ@mail.gmail.com>
 <20170628174900.GG8252@leverpostej> <CAP045Apcdk6wHU9yt3m5x6L_GUoOqnU2DzKeSQj5nHRGQuNuRQ@mail.gmail.com>
 <20170704090313.xyb5lntyy55ga7dm@hirez.programming.kicks-ass.net>
 <20170704093345.GB19649@leverpostej> <20170704102159.GB20062@leverpostej>
From: "Robert O'Callahan" <robert@ocallahan.org>
Date: Wed, 5 Jul 2017 22:07:59 -0700
Message-ID: <CAOp6jLZjGDRiHaitwcV0Jz86WbL=8UocEFCGd_ZXAEYRwtf6nA@mail.gmail.com>
Subject: Re: [PATCH] perf/core: generate overflow signal when samples are
 dropped (WAS: Re: [REGRESSION] perf/core: PMU interrupts dropped if we
 entered the kernel in the "skid" region)
To: Mark Rutland <mark.rutland@arm.com>
Cc: Peter Zijlstra <peterz@infradead.org>, Kyle Huey <me@kylehuey.com>,
        Vince Weaver <vincent.weaver@maine.edu>,
        "Jin, Yao" <yao.jin@linux.intel.com>, Ingo Molnar <mingo@kernel.org>,
        stable@vger.kernel.org,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Arnaldo Carvalho de Melo <acme@redhat.com>,
        Jiri Olsa <jolsa@redhat.com>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Namhyung Kim <namhyung@kernel.org>,
        Stephane Eranian <eranian@google.com>,
        Thomas Gleixner <tglx@linutronix.de>, acme@kernel.org,
        jolsa@kernel.org, kan.liang@intel.com,
        Will Deacon <will.deacon@arm.com>, gregkh@linuxfoundation.org,
        open list <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1096
Lines: 23

On Tue, Jul 4, 2017 at 3:21 AM, Mark Rutland <mark.rutland@arm.com> wrote:
> Should any of those be moved into the "should be dropped" pile?

Why not be conservative and clear every sample you're not sure about?

We'd appreciate a fix sooner rather than later here, since rr is
currently broken on every stable Linux kernel and our attempts to
implement a workaround have failed.

(We have separate "interrupt" and "measure" counters, and I thought we
might work around this regression by programming the "interrupt"
counter to count kernel events as well as user events (interrupting
early is OK), but that caused our (completely separate) "measure"
counter to report off-by-one results (!), which seems to be a
different bug present on a range of older kernels.)

Thanks,
Rob
-- 
lbir ye,ea yer.tnietoehr  rdn rdsme,anea lurpr  edna e hnysnenh hhe uresyf toD
selthor  stor  edna  siewaoeodm  or v sstvr  esBa  kbvted,t rdsme,aoreseoouoto
o l euetiuruewFa  kbn e hnystoivateweh uresyf tulsa rehr  rdm  or rnea lurpr
.a war hsrer holsa rodvted,t  nenh hneireseoouot.tniesiewaoeivatewt sstvr  esn