Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752890AbdGFFZr (ORCPT ); Thu, 6 Jul 2017 01:25:47 -0400 Received: from mail-yb0-f172.google.com ([209.85.213.172]:36108 "EHLO mail-yb0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751034AbdGFFZq (ORCPT ); Thu, 6 Jul 2017 01:25:46 -0400 MIME-Version: 1.0 In-Reply-To: <20170705231417.GA27667@anatevka.americas.hpqcorp.net> References: <20170701195805.GA13259@anatevka.americas.hpqcorp.net> <20170701203813.GA13574@anatevka.americas.hpqcorp.net> <20170704200849.GA15713@anatevka.americas.hpqcorp.net> <20170705162418.GA24924@anatevka.americas.hpqcorp.net> <20170705231417.GA27667@anatevka.americas.hpqcorp.net> From: Dan Williams Date: Wed, 5 Jul 2017 22:25:39 -0700 Message-ID: Subject: Re: [PATCH v4 3/6] libnvdimm, acpi, nfit: Add bus level dsm mask for pass thru. To: Jerry Hoemann Cc: "linux-nvdimm@lists.01.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 975 Lines: 18 On Wed, Jul 5, 2017 at 4:14 PM, Jerry Hoemann wrote: > On Wed, Jul 05, 2017 at 09:35:48AM -0700, Dan Williams wrote: [..] >> It was a mistake to use _DSM for common root-level functionality, and >> we shouldn't double down on that mistake by allowing unfettered > > As to the moral aspects of ACPI's decision to standardiz the DSM for NVDIMM, > I take no position on whether it was a good thing or a bad thing; but it > is a thing. We need to handle it. I see no particular benefit to > making our own lives more difficult. We do handle everything we need to. Making future updates move at the same pace as standard ACPI enabing is the goal as well as not adding any momentum to continue abusing _DSM when we should be creating named methods for bus-level generic functionality. As a maintainer of this subsystem I'm fine with the burden of continuing to touch the code as the specification evolves and that stance matches standard Linux practice.