Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752913AbdGFFqI (ORCPT ); Thu, 6 Jul 2017 01:46:08 -0400 Received: from mail-oi0-f65.google.com ([209.85.218.65]:34835 "EHLO mail-oi0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752671AbdGFFqH (ORCPT ); Thu, 6 Jul 2017 01:46:07 -0400 MIME-Version: 1.0 In-Reply-To: <1499315732-63950-2-git-send-email-guohanjun@huawei.com> References: <1499315732-63950-1-git-send-email-guohanjun@huawei.com> <1499315732-63950-2-git-send-email-guohanjun@huawei.com> From: Ethan Zhao Date: Thu, 6 Jul 2017 13:46:05 +0800 Message-ID: Subject: Re: [PATCH 2/2] genirq: Use is_fwnode_irqchip() directly To: Hanjun Guo Cc: Thomas Gleixner , Marc Zyngier , LKML , Ma Jun , Agustin Vega-Frias , John Garry , Hanjun Guo Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by nfs id v665kJKF005885 Content-Length: 1008 Lines: 34 Hanjun， What branch is this patch for ? Check v4.12, failed to apply. Thanks, Ethan On Thu, Jul 6, 2017 at 12:35 PM, Hanjun Guo wrote: > From: Hanjun Guo > > is_fwnode_irqchip() already check fwnode is NULL or not, > just use is_fwnode_irqchip() directly. > > Signed-off-by: Hanjun Guo > --- > kernel/irq/irqdomain.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/kernel/irq/irqdomain.c b/kernel/irq/irqdomain.c > index 1bc38fa..14a21a3 100644 > --- a/kernel/irq/irqdomain.c > +++ b/kernel/irq/irqdomain.c > @@ -137,7 +137,7 @@ struct irq_domain *__irq_domain_add(struct fwnode_handle *fwnode, int size, > if (WARN_ON(!domain)) > return NULL; > > - if (fwnode && is_fwnode_irqchip(fwnode)) { > + if (is_fwnode_irqchip(fwnode)) { > fwid = container_of(fwnode, struct irqchip_fwid, fwnode); > > switch (fwid->type) { > -- > 1.7.12.4 >