Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753166AbdGFGor (ORCPT ); Thu, 6 Jul 2017 02:44:47 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:37906 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752954AbdGFGoq (ORCPT ); Thu, 6 Jul 2017 02:44:46 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 70DFC60FEE Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=sboyd@codeaurora.org Date: Wed, 5 Jul 2017 23:44:42 -0700 From: Stephen Boyd To: Kiran Gunda Cc: Abhijeet Dharmapurikar , Greg Kroah-Hartman , Nicholas Troast , Christophe JAILLET , linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org Subject: Re: [PATCH V1 4/5] spmi: pmic-arb: return the value instead of passing by pointer Message-ID: <20170706064442.GY22780@codeaurora.org> References: <1499084308-2232-1-git-send-email-kgunda@codeaurora.org> <1499084308-2232-5-git-send-email-kgunda@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1499084308-2232-5-git-send-email-kgunda@codeaurora.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 609 Lines: 15 On 07/03, Kiran Gunda wrote: > Returning the output value from a function, when it is possible, is the > better and cleaner way than passing it by the pointer. Hence, modify > the ppid_to_apid mapping function to return apid instead of passing > it by a pointer. While at it, pass the ppid as function parameter to > ppid_to_apid mapping function instead of passing the sid and addr. > > Signed-off-by: Kiran Gunda > --- Reviewed-by: Stephen Boyd -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project