Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753140AbdGFGqu (ORCPT ); Thu, 6 Jul 2017 02:46:50 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:40038 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752936AbdGFGqs (ORCPT ); Thu, 6 Jul 2017 02:46:48 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 3C97360FEE Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=sboyd@codeaurora.org Date: Wed, 5 Jul 2017 23:46:46 -0700 From: Stephen Boyd To: Kiran Gunda Cc: Abhijeet Dharmapurikar , Nicholas Troast , Greg Kroah-Hartman , Christophe JAILLET , linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org Subject: Re: [PATCH V1 5/5] spmi: pmic-arb: use irq_chip callback to set spmi irq wakeup capability Message-ID: <20170706064646.GZ22780@codeaurora.org> References: <1499084308-2232-1-git-send-email-kgunda@codeaurora.org> <1499084308-2232-6-git-send-email-kgunda@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1499084308-2232-6-git-send-email-kgunda@codeaurora.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 946 Lines: 36 On 07/03, Kiran Gunda wrote: > diff --git a/drivers/spmi/spmi-pmic-arb.c b/drivers/spmi/spmi-pmic-arb.c > index 5285245..2d2e39c 100644 > --- a/drivers/spmi/spmi-pmic-arb.c > +++ b/drivers/spmi/spmi-pmic-arb.c > @@ -621,6 +621,19 @@ static int qpnpint_irq_set_type(struct irq_data *d, unsigned int flow_type) > return 0; > } > > +static int qpnpint_irq_set_wake(struct irq_data *d, unsigned int on) > +{ > + struct spmi_pmic_arb *pmic_arb = irq_data_get_irq_chip_data(d); > + int ret; > + > + if (on) > + ret = enable_irq_wake(pmic_arb->irq); > + else > + ret = disable_irq_wake(pmic_arb->irq); Could be simplified to return irq_set_irq_wake(pmic_arb->irq, on); ? > + > + return ret; > +} > + > static int qpnpint_get_irqchip_state(struct irq_data *d, > enum irqchip_irq_state which, > bool *state) -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project