Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753221AbdGFGsF (ORCPT ); Thu, 6 Jul 2017 02:48:05 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:40446 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753061AbdGFGsE (ORCPT ); Thu, 6 Jul 2017 02:48:04 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 4144960721 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=sboyd@codeaurora.org Date: Wed, 5 Jul 2017 23:48:01 -0700 From: Stephen Boyd To: Kiran Gunda Cc: Abhijeet Dharmapurikar , Nicholas Troast , Christophe JAILLET , linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org Subject: Re: [PATCH V1 1/5] spmi: pmic-arb: remove the read/write access checks Message-ID: <20170706064801.GA22780@codeaurora.org> References: <1499084308-2232-1-git-send-email-kgunda@codeaurora.org> <1499084308-2232-2-git-send-email-kgunda@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1499084308-2232-2-git-send-email-kgunda@codeaurora.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 650 Lines: 16 On 07/03, Kiran Gunda wrote: > The access mode checks for peripheral ownership for read/write > permissions should not be required. Every peripheral enabled for > this master is expected to have a read/write permissions. If there > is any such invalid access due to wrong configuration in boot loader > or device tree files, then it should be fixed in those locations. > Hence, remove the access mode checks from the driver. > > Signed-off-by: Kiran Gunda > --- Reviewed-by: Stephen Boyd -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project