Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753224AbdGFGyB (ORCPT ); Thu, 6 Jul 2017 02:54:01 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:44236 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753130AbdGFGx7 (ORCPT ); Thu, 6 Jul 2017 02:53:59 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org B3F186072E Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=sboyd@codeaurora.org Date: Wed, 5 Jul 2017 23:53:58 -0700 From: Stephen Boyd To: Kiran Gunda Cc: Abhijeet Dharmapurikar , David Collins , linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Fenglin Wu Subject: Re: [PATCH V1 4/4] spmi: pmic-arb: Remove checking opc value not less than 0 Message-ID: <20170706065358.GF22780@codeaurora.org> References: <1499086338-19498-1-git-send-email-kgunda@codeaurora.org> <1499086338-19498-5-git-send-email-kgunda@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1499086338-19498-5-git-send-email-kgunda@codeaurora.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 535 Lines: 16 On 07/03, Kiran Gunda wrote: > From: Fenglin Wu > > The opc parameter in pmic_arb_write_cmd() function is defined with type > u8 and it's always greater than or equal to 0. Checking that it's not > less than 0 is redundant and it can cause a forbidden warning during > compilation. Remove the check. > > Signed-off-by: Fenglin Wu > --- You forgot your sign-off here. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project