Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753122AbdGFHKX (ORCPT ); Thu, 6 Jul 2017 03:10:23 -0400 Received: from mail-ua0-f194.google.com ([209.85.217.194]:36388 "EHLO mail-ua0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752969AbdGFHKU (ORCPT ); Thu, 6 Jul 2017 03:10:20 -0400 MIME-Version: 1.0 In-Reply-To: <1499304152-5383-1-git-send-email-yashomer0007@gmail.com> References: <1499304152-5383-1-git-send-email-yashomer0007@gmail.com> From: Frans Klaver Date: Thu, 6 Jul 2017 09:10:19 +0200 Message-ID: Subject: Re: [PATCH 2/2] Staging: dgnc: I have fixed the changes in dgnc_neo.c This is a patch to the dgnc_neo.c warning udealy to usleep range Signed-off-by: Yash Omer To: yash007 Cc: lidz.louin@gmail.com, markh@compro.net, Greg KH , driverdev-devel@linuxdriverproject.rog, devel@driverdev.osuol.org, "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2191 Lines: 63 On Thu, Jul 6, 2017 at 3:22 AM, yash007 wrote: > From: Yash Omer Your commit message is completely broken. Please fix it. See Documentation/process/submitting-patches.rst chapter 14. > > --- > drivers/staging/dgnc/dgnc_neo.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/staging/dgnc/dgnc_neo.c b/drivers/staging/dgnc/dgnc_neo.c > index 1943e66..0034ebe 100644 > --- a/drivers/staging/dgnc/dgnc_neo.c > +++ b/drivers/staging/dgnc/dgnc_neo.c > @@ -1230,7 +1230,7 @@ static void neo_flush_uart_write(struct channel_t *ch) > */ > tmp = readb(&ch->ch_neo_uart->isr_fcr); > if (tmp & 4) > - udelay(10); > + usleep_range(10); > else > break; > } > @@ -1261,7 +1261,7 @@ static void neo_flush_uart_read(struct channel_t *ch) > */ > tmp = readb(&ch->ch_neo_uart->isr_fcr); > if (tmp & 2) > - udelay(10); > + usleep_range(10); > else > break; > } > @@ -1483,7 +1483,7 @@ static void neo_assert_modem_signals(struct channel_t *ch) > neo_pci_posting_flush(ch->ch_bd); > > /* Give time for the UART to actually raise/drop the signals */ > - udelay(10); > + usleep_range(10); > } > > static void neo_send_start_character(struct channel_t *ch) > @@ -1495,7 +1495,7 @@ static void neo_send_start_character(struct channel_t *ch) > ch->ch_xon_sends++; > writeb(ch->ch_startc, &ch->ch_neo_uart->txrx); > neo_pci_posting_flush(ch->ch_bd); > - udelay(10); > + usleep_range(10); > } > } > > @@ -1508,7 +1508,7 @@ static void neo_send_stop_character(struct channel_t *ch) > ch->ch_xoff_sends++; > writeb(ch->ch_stopc, &ch->ch_neo_uart->txrx); > neo_pci_posting_flush(ch->ch_bd); > - udelay(10); > + usleep_range(10); > } > } > > -- > 2.1.4 >