Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753246AbdGFHZI (ORCPT ); Thu, 6 Jul 2017 03:25:08 -0400 Received: from mail-qk0-f195.google.com ([209.85.220.195]:35730 "EHLO mail-qk0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751057AbdGFHZH (ORCPT ); Thu, 6 Jul 2017 03:25:07 -0400 MIME-Version: 1.0 In-Reply-To: <20170705211518.GU22780@codeaurora.org> References: <1499011768-8046-1-git-send-email-vincent.legoll@gmail.com> <20170705211518.GU22780@codeaurora.org> From: Vincent Legoll Date: Thu, 6 Jul 2017 09:25:05 +0200 Message-ID: Subject: Re: [PATCH] Make Common clock framework a menuconfig to ease disabling it all To: Stephen Boyd Cc: Linux Kernel ML , Michael Turquette , linux-clk@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1065 Lines: 35 Hello, On Wed, Jul 5, 2017 at 11:15 PM, Stephen Boyd wrote: > On 07/02, Vincent Legoll wrote: >> -menu "Common Clock Framework" >> +menuconfig COMMON_CLK_FRAMEWORK >> + tristate "Common Clock Framework" >> depends on COMMON_CLK > > Wouldn't this put the clk drivers inside the drivers menu? This does not move anything (at least I think), it just change the already existing submenu into a menuconfig, which you can choose to disable as a whole, which disable everything inside that menuconfig. Maybe there are side effects visible outside of this menu. > Which is already quite large right now. That's right, and I'm willing to tackle at least a part of this problem, first by making it easier to disable whole chunks at once. > Plus this makes common clk > tristate which so far we haven't supported. No thanks. OK that was an oversight, I'll revisit later (going for the low hanging fruits). But this is moot anyways, you should drop that patch because it introduces new compile warnings on ARM. Sorry -- Vincent Legoll