Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752735AbdGFIA2 (ORCPT ); Thu, 6 Jul 2017 04:00:28 -0400 Received: from mx08-00178001.pphosted.com ([91.207.212.93]:31158 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750778AbdGFIA0 (ORCPT ); Thu, 6 Jul 2017 04:00:26 -0400 From: Hugues FRUCHET To: Sylwester Nawrocki CC: "H. Nikolaus Schaller" , Guennadi Liakhovetski , Rob Herring , Mark Rutland , Maxime Coquelin , Alexandre TORGUE , Mauro Carvalho Chehab , Hans Verkuil , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "linux-media@vger.kernel.org" , Benjamin Gaignard , Yannick FERTRE Subject: Re: [PATCH v2 0/7] [PATCH v2 0/7] Add support of OV9655 camera Thread-Topic: [PATCH v2 0/7] [PATCH v2 0/7] Add support of OV9655 camera Thread-Index: AQHS890Jv/3Hvsb23UGHm/yJrpLIDKJGUBaA Date: Thu, 6 Jul 2017 07:51:28 +0000 Message-ID: <26a55285-509c-b7f4-7806-db537a582631@st.com> References: <1499073368-31905-1-git-send-email-hugues.fruchet@st.com> In-Reply-To: <1499073368-31905-1-git-send-email-hugues.fruchet@st.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 x-ms-exchange-messagesentrepresentingtype: 1 x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.75.127.44] Content-Type: text/plain; charset="utf-8" Content-ID: <415F1E55B17EAC40A4EBEE19A8753DEF@st.com> MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-07-06_04:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id v6680rr4016625 Content-Length: 3585 Lines: 75 Hi Sylwester, Do you have the possibility to check for non-regression of this patchset on 9650/52 camera ? Best regards, Hugues. On 07/03/2017 11:16 AM, Hugues Fruchet wrote: > This patchset enables OV9655 camera support. > > OV9655 support has been tested using STM32F4DIS-CAM extension board > plugged on connector P1 of STM32F746G-DISCO board. > Due to lack of OV9650/52 hardware support, the modified related code > could not have been checked for non-regression. > > First patches upgrade current support of OV9650/52 to prepare then > introduction of OV9655 variant patch. > Because of OV9655 register set slightly different from OV9650/9652, > not all of the driver features are supported (controls). Supported > resolutions are limited to VGA, QVGA, QQVGA. > Supported format is limited to RGB565. > Controls are limited to color bar test pattern for test purpose. > > OV9655 initial support is based on a driver written by H. Nikolaus Schaller [1]. > OV9655 registers sequences come from STM32CubeF7 embedded software [2]. > > [1] http://git.goldelico.com/?p=gta04-kernel.git;a=shortlog;h=refs/heads/work/hns/video/ov9655 > [2] https://developer.mbed.org/teams/ST/code/BSP_DISCO_F746NG/file/e1d9da7fe856/Drivers/BSP/Components/ov9655/ov9655.c > > =========== > = history = > =========== > version 2: > - Remove some unneeded semicolons (kbuild test robot): > http://www.mail-archive.com/linux-media@vger.kernel.org/msg114616.html > - Remove patch [media] ov9650: select the nearest higher resolution: > it is up to the application to find the best matching resolution > using ENUM_FRAMESIZES/S_FMT/S_SELECTION (S_CROP), see > http://www.mail-archive.com/linux-media@vger.kernel.org/msg114667.html > - dt-bindings: Fix remarks from Rob Herring about polarity: > http://www.mail-archive.com/linux-media@vger.kernel.org/msg114705.html > - dt-bindings: Add optional regulators avdd, dvdd, dovdd: > http://www.mail-archive.com/linux-media@vger.kernel.org/msg114785.html > - fix missing semicolons in if condition: > http://www.mail-archive.com/linux-media@vger.kernel.org/msg114611.html > - move ov965x_pixfmt relocation in right patch: > http://www.mail-archive.com/linux-media@vger.kernel.org/msg114849.html > - revisit OV965x renaming to ov965x for device id names and DT compatible strings, > drop of_device_id .data device identification > http://www.mail-archive.com/linux-media@vger.kernel.org/msg114635.html > http://www.mail-archive.com/linux-media@vger.kernel.org/msg114738.html > - Add analog power supply and clock gating, needed for GTA04 platform: > http://www.mail-archive.com/linux-media@vger.kernel.org/msg114519.html > > version 1: > - Initial submission. > > H. Nikolaus Schaller (1): > DT bindings: add bindings for ov965x camera module > > Hugues Fruchet (6): > [media] ov9650: switch i2c device id to lower case > [media] ov9650: add device tree support > [media] ov9650: use write_array() for resolution sequences > [media] ov9650: add multiple variant support > [media] ov9650: add support of OV9655 variant > [media] ov9650: add analog power supply and clock gating > > .../devicetree/bindings/media/i2c/ov965x.txt | 45 ++ > drivers/media/i2c/Kconfig | 6 +- > drivers/media/i2c/ov9650.c | 816 +++++++++++++++++---- > 3 files changed, 736 insertions(+), 131 deletions(-) > create mode 100644 Documentation/devicetree/bindings/media/i2c/ov965x.txt >