Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752013AbdGFIeK (ORCPT ); Thu, 6 Jul 2017 04:34:10 -0400 Received: from sci-ig2.spreadtrum.com ([222.66.158.135]:57423 "EHLO SHSQR01.spreadtrum.com" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1750998AbdGFIeJ (ORCPT ); Thu, 6 Jul 2017 04:34:09 -0400 Date: Thu, 6 Jul 2017 16:30:16 +0800 From: Baolin Wang To: Chunyan Zhang CC: , Mark Rutland , "robh+dt@kernel.org" , , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Mark Brown , , Orson Zhai =?utf-8?B?KOe/n+S6rCk=?= Subject: Re: [PATCH v3 2/2] i2c: Add Spreadtrum I2C controller driver Message-ID: <20170706083015.GA6751@spreadtrum.com> Mail-Followup-To: Chunyan Zhang , wsa@the-dreams.de, Mark Rutland , "robh+dt@kernel.org" , linux-i2c@vger.kernel.org, "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Mark Brown , baolin.wang@linaro.org, Orson Zhai =?utf-8?B?KOe/n+S6rCk=?= References: <2083c9d6e96a72f9c1324c8a277acfd780a34094.1498472593.git.baolin.wang@spreadtrum.com> <6941c6866078fac8fe81d108b573f7408245a0b9.1498472593.git.baolin.wang@spreadtrum.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-MAIL: SHSQR01.spreadtrum.com v668XM7A099925 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2387 Lines: 65 Hi Chunyan, On 一, 7月 03, 2017 at 05:29:57下午 +0800, Chunyan Zhang wrote: > Hi Baolin, > > On 26 June 2017 at 18:28, Baolin Wang wrote: > > This patch adds the I2C controller driver for Spreadtrum SC9860 platform. > > > > Signed-off-by: Baolin Wang > > --- > > Changes since v2: > > - Remove some redundant comments and parens. > > - Define macros instead of magic number. > > - Add some comments to explain clock formula. > > - Change of_clk_get_by_name() to devm_clk_get(). > > - Deal with other frequency. > > - Change register definiton to low case. > > - Change is_last_msg to boolean. > > - Other optimization. > > > > Changes sice v1: > > - Power on I2C device in probe(). > > - Remove redundant macros and usb __maybe_unused. > > - Remove redundant 'of_match_ptr'. > > - Modify return values and check the return value for 'clk_prepare_enable'. > > --- > > drivers/i2c/busses/Kconfig | 7 + > > drivers/i2c/busses/Makefile | 1 + > > drivers/i2c/busses/i2c-sprd.c | 683 +++++++++++++++++++++++++++++++++++++++++ > > 3 files changed, 691 insertions(+) > > create mode 100644 drivers/i2c/busses/i2c-sprd.c > > > > [snip] > > > diff --git a/drivers/i2c/busses/i2c-sprd.c b/drivers/i2c/busses/i2c-sprd.c > > new file mode 100644 > > index 0000000..a070f61 > > --- /dev/null > > +++ b/drivers/i2c/busses/i2c-sprd.c > > @@ -0,0 +1,683 @@ > > +/* > > + * Copyright (C) 2017 Spreadtrum Communications Inc. > > + * > > + * This software is licensed under the terms of the GNU General Public > > + * License version 2, as published by the Free Software Foundation, and > > + * may be copied, distributed, and modified under those terms. > > + * > > + * This program is distributed in the hope that it will be useful, > > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > > + * GNU General Public License for more details. > > + */ > > According to RobH's comments [1], we're switching to use > SPDX-License-Identifier tag instead, like [2]. > > [1] http://lkml.iu.edu/hypermail/linux/kernel/1702.2/05122.html > [2] http://elixir.free-electrons.com/linux/v4.12/source/arch/arm64/boot/dts/sprd/sp9860g-1h10.dts#L6 Will use SPDX-License-Identifier tag instead and resend. Thanks. > > Thanks, > Chunyan