Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751952AbdGFJVF (ORCPT ); Thu, 6 Jul 2017 05:21:05 -0400 Received: from mail-pg0-f65.google.com ([74.125.83.65]:34688 "EHLO mail-pg0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750778AbdGFJVE (ORCPT ); Thu, 6 Jul 2017 05:21:04 -0400 From: jrjang@gmail.com Cc: jrjang@gmail.com, Thomas Gleixner , Jason Cooper , Marc Zyngier , linux-kernel@vger.kernel.org Subject: [PATCH v2] irqchip/mips-gic: Add missing shared interrupt handler Date: Thu, 6 Jul 2017 17:20:58 +0800 Message-Id: <20170706092058.20079-1-jrjang@gmail.com> X-Mailer: git-send-email 2.13.2 In-Reply-To: References: To: unlisted-recipients:; (no To-header on input) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1241 Lines: 36 From: Jun-Ru Chang Commit b87281e7f205 ("irqchip/mips-gic: Remove device IRQ domain") removes the device IRQ domain and uses gic_irq_domain_alloc() to allocate the shared/local domain. However, the shared interrupt handler is not set after allocating. It causes that the system hangs with "unexpected IRQ" messages disaply. And commit 8ada00a650ec ("irqchip/mips-gic: Replace static map with dynamic") renames gic_irq_domain_alloc() to gic_irq_domain_map() to set up the handler and chip. Fix this by setting the handle_level_irq handler for shared interrupts. Fixes: b87281e7f205 ("irqchip/mips-gic: Remove device IRQ domain") Signed-off-by: Jun-Ru Chang --- Change in v2: - changed commit message drivers/irqchip/irq-mips-gic.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/irqchip/irq-mips-gic.c b/drivers/irqchip/irq-mips-gic.c index 929f8558bf1c..0a5fb30deb17 100644 --- a/drivers/irqchip/irq-mips-gic.c +++ b/drivers/irqchip/irq-mips-gic.c @@ -716,6 +716,7 @@ static int gic_irq_domain_map(struct irq_domain *d, unsigned int virq, if (err) return err; + irq_set_handler(virq, handle_level_irq); return gic_shared_irq_domain_map(d, virq, hwirq, 0); } -- 2.13.2