Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752619AbdGFJne (ORCPT ); Thu, 6 Jul 2017 05:43:34 -0400 Received: from mail-pg0-f65.google.com ([74.125.83.65]:35553 "EHLO mail-pg0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752599AbdGFJnd (ORCPT ); Thu, 6 Jul 2017 05:43:33 -0400 Subject: Re: [PATCH] input: coresight: Fix redefinition error on compilation. To: gregkh@linuxfoundation.org, mathieu.poirier@linaro.org References: <6333cde19a5c0adc8faf41531c2ae431cd79e7a6.1499332268.git.arvind.yadav.cs@gmail.com> Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org From: Arvind Yadav Message-ID: Date: Thu, 6 Jul 2017 15:13:13 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <6333cde19a5c0adc8faf41531c2ae431cd79e7a6.1499332268.git.arvind.yadav.cs@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1529 Lines: 40 Sorry for noise. Please ignore this patch. On Thursday 06 July 2017 02:45 PM, Arvind Yadav wrote: > If CONFIG_CORESIGHT is disable, it'll through compilation error. > > drivers/hwtracing/coresight/coresight-etm-perf.c:462:5: error: redefinition of ‘etm_perf_symlink’ > int etm_perf_symlink(struct coresight_device *csdev, bool link) > ^ > In file included from drivers/hwtracing/coresight/coresight-etm-perf.c:30:0: > drivers/hwtracing/coresight/coresight-etm-perf.h:61:19: note: previous definition of ‘etm_perf_symlink’ was here > static inline int etm_perf_symlink(struct coresight_device *csdev, bool link) > > Signed-off-by: Arvind Yadav > --- > drivers/hwtracing/coresight/coresight-etm-perf.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/hwtracing/coresight/coresight-etm-perf.c b/drivers/hwtracing/coresight/coresight-etm-perf.c > index e97775d..74ce6a5 100644 > --- a/drivers/hwtracing/coresight/coresight-etm-perf.c > +++ b/drivers/hwtracing/coresight/coresight-etm-perf.c > @@ -458,7 +458,7 @@ static void etm_addr_filters_sync(struct perf_event *event) > > filters->nr_filters = i; > } > - > +#ifdef CONFIG_CORESIGHT > int etm_perf_symlink(struct coresight_device *csdev, bool link) > { > char entry[sizeof("cpu9999999")]; > @@ -483,7 +483,7 @@ int etm_perf_symlink(struct coresight_device *csdev, bool link) > > return 0; > } > - > +#endif > static int __init etm_perf_init(void) > { > int ret;