Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752220AbdGFKN2 (ORCPT ); Thu, 6 Jul 2017 06:13:28 -0400 Received: from lb3-smtp-cloud2.xs4all.net ([194.109.24.29]:54484 "EHLO lb3-smtp-cloud2.xs4all.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751865AbdGFKN1 (ORCPT ); Thu, 6 Jul 2017 06:13:27 -0400 Subject: Re: [PATCH] clk: qcom: clk-smd-rpm: Fix the initial rate of branches To: Archit Taneja , Georgi Djakov , sboyd@codeaurora.org References: <20170704123447.25552-1-georgi.djakov@linaro.org> <1f0f3d8d-f71b-2483-40a1-ad64c437bf6a@codeaurora.org> Cc: mturquette@baylibre.com, andy.gross@linaro.org, bjorn.andersson@linaro.org, linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org From: Hans Verkuil Message-ID: <53436d44-f2d9-7e16-e0a5-bab316096cc2@xs4all.nl> Date: Thu, 6 Jul 2017 12:13:20 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: <1f0f3d8d-f71b-2483-40a1-ad64c437bf6a@codeaurora.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2074 Lines: 57 On 07/06/17 11:53, Archit Taneja wrote: > > > On 07/04/2017 06:04 PM, Georgi Djakov wrote: >> As there is no way to actually query the hardware for the current clock >> rate, now racalc_rate() just returns the last rate that was previously >> set. But if the rate was not set yet, we return the bogus rate of 1KHz. >> >> Knowing what the rate of XO is and that some clocks are just branches of >> it, we can do better and return that rate instead of a bogus one. > > +Hans. > > Thanks for the fix. > > Reviewed-by: Archit Taneja Tested-by: Hans Verkuil (Tested with the upcoming HDMI CEC driver for the adv7511/33) Regards, Hans >> >> Reported-by: Archit Taneja >> Signed-off-by: Georgi Djakov >> --- >> drivers/clk/qcom/clk-smd-rpm.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/clk/qcom/clk-smd-rpm.c b/drivers/clk/qcom/clk-smd-rpm.c >> index d990fe44aef3..7350a43b0573 100644 >> --- a/drivers/clk/qcom/clk-smd-rpm.c >> +++ b/drivers/clk/qcom/clk-smd-rpm.c >> @@ -116,12 +116,12 @@ >> >> #define DEFINE_CLK_SMD_RPM_XO_BUFFER(_platform, _name, _active, r_id) \ >> __DEFINE_CLK_SMD_RPM_BRANCH(_platform, _name, _active, \ >> - QCOM_SMD_RPM_CLK_BUF_A, r_id, 0, 1000, \ >> + QCOM_SMD_RPM_CLK_BUF_A, r_id, 0, 19200000, \ >> QCOM_RPM_KEY_SOFTWARE_ENABLE) >> >> #define DEFINE_CLK_SMD_RPM_XO_BUFFER_PINCTRL(_platform, _name, _active, r_id) \ >> __DEFINE_CLK_SMD_RPM_BRANCH(_platform, _name, _active, \ >> - QCOM_SMD_RPM_CLK_BUF_A, r_id, 0, 1000, \ >> + QCOM_SMD_RPM_CLK_BUF_A, r_id, 0, 19200000, \ >> QCOM_RPM_KEY_PIN_CTRL_CLK_BUFFER_ENABLE_KEY) >> >> #define to_clk_smd_rpm(_hw) container_of(_hw, struct clk_smd_rpm, hw) >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html >> >