Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752149AbdGFKWA (ORCPT ); Thu, 6 Jul 2017 06:22:00 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:34888 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751059AbdGFKV6 (ORCPT ); Thu, 6 Jul 2017 06:21:58 -0400 MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Thu, 06 Jul 2017 15:51:57 +0530 From: kgunda@codeaurora.org To: Stephen Boyd Cc: Abhijeet Dharmapurikar , David Collins , linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Fenglin Wu , linux-arm-msm-owner@vger.kernel.org Subject: Re: [PATCH V1 4/4] spmi: pmic-arb: Remove checking opc value not less than 0 In-Reply-To: <20170706065358.GF22780@codeaurora.org> References: <1499086338-19498-1-git-send-email-kgunda@codeaurora.org> <1499086338-19498-5-git-send-email-kgunda@codeaurora.org> <20170706065358.GF22780@codeaurora.org> Message-ID: <740ccb0a99eb927fb02965018b7d1619@codeaurora.org> User-Agent: Roundcube Webmail/1.2.5 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 510 Lines: 15 On 2017-07-06 12:23, Stephen Boyd wrote: > On 07/03, Kiran Gunda wrote: >> From: Fenglin Wu >> >> The opc parameter in pmic_arb_write_cmd() function is defined with >> type >> u8 and it's always greater than or equal to 0. Checking that it's not >> less than 0 is redundant and it can cause a forbidden warning during >> compilation. Remove the check. >> >> Signed-off-by: Fenglin Wu >> --- > > You forgot your sign-off here. yeah.. forgot. Will add it.