Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752355AbdGFK3s (ORCPT ); Thu, 6 Jul 2017 06:29:48 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:46578 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751850AbdGFK3r (ORCPT ); Thu, 6 Jul 2017 06:29:47 -0400 Date: Thu, 6 Jul 2017 12:29:40 +0200 From: Heiko Carstens To: Joe Perches Cc: Andrew Morton , Julian Wiedmann , Ursula Braun , Martin Schwidefsky , linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 12/18] drivers: s390: Move static and inline before return type References: <3f980cd89084ae09716353aba3171e4b3815e690.1499284835.git.joe@perches.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3f980cd89084ae09716353aba3171e4b3815e690.1499284835.git.joe@perches.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-TM-AS-GCONF: 00 x-cbid: 17070610-0012-0000-0000-000005601D5F X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17070610-0013-0000-0000-000018D28D58 Message-Id: <20170706102940.GG3217@osiris> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-07-06_05:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1703280000 definitions=main-1707060182 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 910 Lines: 24 On Wed, Jul 05, 2017 at 01:02:21PM -0700, Joe Perches wrote: > Make the code like the rest of the kernel. > > Signed-off-by: Joe Perches > --- > drivers/s390/net/ctcm_main.c | 2 +- > drivers/s390/net/qeth_l3_main.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > diff --git a/drivers/s390/net/qeth_l3_main.c b/drivers/s390/net/qeth_l3_main.c > index 3062cde33a3d..8975cd321390 100644 > --- a/drivers/s390/net/qeth_l3_main.c > +++ b/drivers/s390/net/qeth_l3_main.c > @@ -2408,7 +2408,7 @@ static int qeth_l3_do_ioctl(struct net_device *dev, struct ifreq *rq, int cmd) > return rc; > } > > -int inline qeth_l3_get_cast_type(struct qeth_card *card, struct sk_buff *skb) > +inline int qeth_l3_get_cast_type(struct qeth_card *card, struct sk_buff *skb) > { Actually the function could be made static, and "inline" should be removed, considering the large function body.