Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752361AbdGFKaZ (ORCPT ); Thu, 6 Jul 2017 06:30:25 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:45004 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751850AbdGFKaX (ORCPT ); Thu, 6 Jul 2017 06:30:23 -0400 MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Thu, 06 Jul 2017 16:00:22 +0530 From: kgunda@codeaurora.org To: Stephen Boyd Cc: Abhijeet Dharmapurikar , Nicholas Troast , Greg Kroah-Hartman , Christophe JAILLET , linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-arm-msm-owner@vger.kernel.org Subject: Re: [PATCH V1 5/5] spmi: pmic-arb: use irq_chip callback to set spmi irq wakeup capability In-Reply-To: <20170706064646.GZ22780@codeaurora.org> References: <1499084308-2232-1-git-send-email-kgunda@codeaurora.org> <1499084308-2232-6-git-send-email-kgunda@codeaurora.org> <20170706064646.GZ22780@codeaurora.org> Message-ID: <1f9393918c769877d28754036596fac1@codeaurora.org> User-Agent: Roundcube Webmail/1.2.5 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 941 Lines: 36 On 2017-07-06 12:16, Stephen Boyd wrote: > On 07/03, Kiran Gunda wrote: >> diff --git a/drivers/spmi/spmi-pmic-arb.c >> b/drivers/spmi/spmi-pmic-arb.c >> index 5285245..2d2e39c 100644 >> --- a/drivers/spmi/spmi-pmic-arb.c >> +++ b/drivers/spmi/spmi-pmic-arb.c >> @@ -621,6 +621,19 @@ static int qpnpint_irq_set_type(struct irq_data >> *d, unsigned int flow_type) >> return 0; >> } >> >> +static int qpnpint_irq_set_wake(struct irq_data *d, unsigned int on) >> +{ >> + struct spmi_pmic_arb *pmic_arb = irq_data_get_irq_chip_data(d); >> + int ret; >> + >> + if (on) >> + ret = enable_irq_wake(pmic_arb->irq); >> + else >> + ret = disable_irq_wake(pmic_arb->irq); > > Could be simplified to > > return irq_set_irq_wake(pmic_arb->irq, on); > > ? > yes. Will modify it. >> + >> + return ret; >> +} >> + >> static int qpnpint_get_irqchip_state(struct irq_data *d, >> enum irqchip_irq_state which, >> bool *state)