Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752426AbdGFK56 (ORCPT ); Thu, 6 Jul 2017 06:57:58 -0400 Received: from mail-pf0-f174.google.com ([209.85.192.174]:34792 "EHLO mail-pf0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751865AbdGFK54 (ORCPT ); Thu, 6 Jul 2017 06:57:56 -0400 Date: Thu, 6 Jul 2017 16:27:53 +0530 From: Viresh Kumar To: Dietmar Eggemann Cc: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux@arm.linux.org.uk, Greg Kroah-Hartman , Russell King , Catalin Marinas , Will Deacon , Juri Lelli , Vincent Guittot , Peter Zijlstra , Morten Rasmussen , "Rafael J . Wysocki" Subject: Re: [PATCH v2 10/10] drivers base/arch_topology: inline cpu- and frequency-invariant accounting Message-ID: <20170706105753.GA1523@vireshk-i7> References: <20170706094948.8779-1-dietmar.eggemann@arm.com> <20170706094948.8779-11-dietmar.eggemann@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170706094948.8779-11-dietmar.eggemann@arm.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 961 Lines: 30 Sure this patch looks pretty useful, but ... On 06-07-17, 10:49, Dietmar Eggemann wrote: > diff --git a/drivers/base/arch_topology.c b/drivers/base/arch_topology.c > index 63fb3f945d21..b4481cff14bf 100644 > --- a/drivers/base/arch_topology.c > +++ b/drivers/base/arch_topology.c > @@ -22,12 +22,7 @@ > #include > #include > > -static DEFINE_PER_CPU(unsigned long, freq_scale) = SCHED_CAPACITY_SCALE; > - > -unsigned long topology_get_freq_scale(struct sched_domain *sd, int cpu) > -{ > - return per_cpu(freq_scale, cpu); > -} > +DEFINE_PER_CPU(unsigned long, freq_scale) = SCHED_CAPACITY_SCALE; ... you just undo what you did earlier in this series, and that is somewhat discouraged. What about making this as the first patch of the series and move only the below part to the header. And then you can add the above part to the right place in the first attempt itself? But maybe this is all okay :) -- viresh