Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752257AbdGFMEF (ORCPT ); Thu, 6 Jul 2017 08:04:05 -0400 Received: from Galois.linutronix.de ([146.0.238.70]:56183 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751850AbdGFMEE (ORCPT ); Thu, 6 Jul 2017 08:04:04 -0400 Date: Thu, 6 Jul 2017 14:03:59 +0200 (CEST) From: Thomas Gleixner To: jrjang@gmail.com cc: Jason Cooper , Marc Zyngier , LKML , Paul Burton , Matt Redfearn , Ralf Baechle Subject: Re: [PATCH v2] irqchip/mips-gic: Add missing shared interrupt handler In-Reply-To: <20170706092058.20079-1-jrjang@gmail.com> Message-ID: References: <20170706092058.20079-1-jrjang@gmail.com> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1435 Lines: 41 On Thu, 6 Jul 2017, jrjang@gmail.com wrote: CC+ MIPS folks. There is a reason WHY I added them to my previous reply. > From: Jun-Ru Chang > > Commit b87281e7f205 ("irqchip/mips-gic: Remove device IRQ domain") > removes the device IRQ domain and uses gic_irq_domain_alloc() to > allocate the shared/local domain. However, the shared interrupt handler > is not set after allocating. It causes that the system hangs with > "unexpected IRQ" messages disaply. > > And commit 8ada00a650ec ("irqchip/mips-gic: Replace static map with > dynamic") renames gic_irq_domain_alloc() to gic_irq_domain_map() to set > up the handler and chip. Fix this by setting the handle_level_irq > handler for shared interrupts. > > Fixes: b87281e7f205 ("irqchip/mips-gic: Remove device IRQ domain") > Signed-off-by: Jun-Ru Chang > --- > Change in v2: > - changed commit message > > drivers/irqchip/irq-mips-gic.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/irqchip/irq-mips-gic.c b/drivers/irqchip/irq-mips-gic.c > index 929f8558bf1c..0a5fb30deb17 100644 > --- a/drivers/irqchip/irq-mips-gic.c > +++ b/drivers/irqchip/irq-mips-gic.c > @@ -716,6 +716,7 @@ static int gic_irq_domain_map(struct irq_domain *d, unsigned int virq, > if (err) > return err; > > + irq_set_handler(virq, handle_level_irq); > return gic_shared_irq_domain_map(d, virq, hwirq, 0); > } > > -- > 2.13.2 >