Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752545AbdGFNA2 (ORCPT ); Thu, 6 Jul 2017 09:00:28 -0400 Received: from szxga03-in.huawei.com ([45.249.212.189]:8878 "EHLO szxga03-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751994AbdGFNA0 (ORCPT ); Thu, 6 Jul 2017 09:00:26 -0400 Subject: Re: [PATCH v6 0/3] Add new PCI_DEV_FLAGS_NO_RELAXED_ORDERING flag To: , , , , , , , , , , , , , , , , , , , , , , , References: <1498133721-21152-1-git-send-email-dingtianhong@huawei.com> <43e01fca-a746-90d2-fdfa-c63f1d56ef5f@huawei.com> From: Ding Tianhong Message-ID: <065edbdb-3a7f-2608-3cc0-3876f55d414b@huawei.com> Date: Thu, 6 Jul 2017 20:58:51 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <43e01fca-a746-90d2-fdfa-c63f1d56ef5f@huawei.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.177.23.32] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020202.595E341D.016F,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2014-11-16 11:51:01, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: 4d68fe2a8e86e65fcbf89d1fb3981d0f Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 4031 Lines: 83 Hi Bjorn: Could you please give some feedback about this patchset, it looks like no more comments for more than a week, thanks. :) Ding On 2017/6/29 13:47, Ding Tianhong wrote: > ping > > On 2017/6/22 20:15, Ding Tianhong wrote: >> Some devices have problems with Transaction Layer Packets with the Relaxed >> Ordering Attribute set. This patch set adds a new PCIe Device Flag, >> PCI_DEV_FLAGS_NO_RELAXED_ORDERING, a set of PCI Quirks to catch some known >> devices with Relaxed Ordering issues, and a use of this new flag by the >> cxgb4 driver to avoid using Relaxed Ordering with problematic Root Complex >> Ports. >> >> It's been years since I've submitted kernel.org patches, I appolgise for the >> almost certain submission errors. >> >> v2: Alexander point out that the v1 was only a part of the whole solution, >> some platform which has some issues could use the new flag to indicate >> that it is not safe to enable relaxed ordering attribute, then we need >> to clear the relaxed ordering enable bits in the PCI configuration when >> initializing the device. So add a new second patch to modify the PCI >> initialization code to clear the relaxed ordering enable bit in the >> event that the root complex doesn't want relaxed ordering enabled. >> >> The third patch was base on the v1's second patch and only be changed >> to query the relaxed ordering enable bit in the PCI configuration space >> to allow the Chelsio NIC to send TLPs with the relaxed ordering attributes >> set. >> >> This version didn't plan to drop the defines for Intel Drivers to use the >> new checking way to enable relaxed ordering because it is not the hardest >> part of the moment, we could fix it in next patchset when this patches >> reach the goal. >> >> v3: Redesigned the logic for pci_configure_relaxed_ordering when configuration, >> If a PCIe device didn't enable the relaxed ordering attribute default, >> we should not do anything in the PCIe configuration, otherwise we >> should check if any of the devices above us do not support relaxed >> ordering by the PCI_DEV_FLAGS_NO_RELAXED_ORDERING flag, then base on >> the result if we get a return that indicate that the relaxed ordering >> is not supported we should update our device to disable relaxed ordering >> in configuration space. If the device above us doesn't exist or isn't >> the PCIe device, we shouldn't do anything and skip updating relaxed ordering >> because we are probably running in a guest. >> >> v4: Rename the functions pcie_get_relaxed_ordering and pcie_disable_relaxed_ordering >> according John's suggestion, and modify the description, use the true/false >> as the return value. >> >> We shouldn't enable relaxed ordering attribute by the setting in the root >> complex configuration space for PCIe device, so fix it for cxgb4. >> >> Fix some format issues. >> >> v5: Removed the unnecessary code for some function which only return the bool >> value, and add the check for VF device. >> >> Make this patch set base on 4.12-rc5. >> >> v6: Fix the logic error in the need to enable the relaxed ordering attribute for cxgb4. >> >> Casey Leedom (2): >> PCI: Add new PCIe Fabric End Node flag, >> PCI_DEV_FLAGS_NO_RELAXED_ORDERING >> net/cxgb4: Use new PCI_DEV_FLAGS_NO_RELAXED_ORDERING flag >> >> Ding Tianhong (1): >> PCI: Enable PCIe Relaxed Ordering if supported >> >> drivers/net/ethernet/chelsio/cxgb4/cxgb4.h | 1 + >> drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c | 17 ++++++++++ >> drivers/net/ethernet/chelsio/cxgb4/sge.c | 5 +-- >> drivers/pci/pci.c | 32 +++++++++++++++++++ >> drivers/pci/probe.c | 41 +++++++++++++++++++++++++ >> drivers/pci/quirks.c | 38 +++++++++++++++++++++++ >> include/linux/pci.h | 4 +++ >> 7 files changed, 136 insertions(+), 2 deletions(-) >>