Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752721AbdGFNHE (ORCPT ); Thu, 6 Jul 2017 09:07:04 -0400 Received: from mail-pf0-f193.google.com ([209.85.192.193]:35172 "EHLO mail-pf0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752068AbdGFNHB (ORCPT ); Thu, 6 Jul 2017 09:07:01 -0400 Date: Thu, 6 Jul 2017 22:06:58 +0900 From: Stafford Horne To: Steven Rostedt Cc: Masami Hiramatsu , linux-kselftest@vger.kernel.org, shuah@kernel.org, Ingo Molnar , linux-kernel@vger.kernel.org, naresh.kamboju@linaro.org Subject: Re: [PATCH 4/4] selftests: ftrace: Output only to console with "--logdir -" Message-ID: <20170706130658.GC2511@lianli.shorne-pla.net> References: <149915006959.18583.13997841764160473197.stgit@devbox> <149915032497.18583.11626955093827357641.stgit@devbox> <20170705122506.6235765e@gandalf.local.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170705122506.6235765e@gandalf.local.home> User-Agent: Mutt/1.8.3 (2017-05-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 471 Lines: 20 On Wed, Jul 05, 2017 at 12:25:06PM -0400, Steven Rostedt wrote: > On Tue, 4 Jul 2017 15:38:55 +0900 > Masami Hiramatsu wrote: > > > + local testlog=`mktemp $LOG_DIR/${testname}-log.XXXXXX` > > + else > > + local testlog=`/proc/self/fd/1` > > cute trick. Shouldn't this be: local testlog=/proc/self/fd/1 without the backticks and subshell? We just want to write to the stdout file not execute it. Or am missing something. -Stafford