DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 695E32156A
Date: Thu, 6 Jul 2017 09:18:02 -0400
From: Steven Rostedt <rostedt@goodmis.org>
To: Stafford Horne <shorne@gmail.com>
Cc: Masami Hiramatsu <mhiramat@kernel.org>,
        linux-kselftest@vger.kernel.org, shuah@kernel.org,
        Ingo Molnar <mingo@redhat.com>, linux-kernel@vger.kernel.org,
        naresh.kamboju@linaro.org
Subject: Re: [PATCH 4/4] selftests: ftrace: Output only to console with
 "--logdir -"
Message-ID: <20170706091802.4b150663@gandalf.local.home>
In-Reply-To: <20170706130658.GC2511@lianli.shorne-pla.net>
References: <149915006959.18583.13997841764160473197.stgit@devbox>
        <149915032497.18583.11626955093827357641.stgit@devbox>
        <20170705122506.6235765e@gandalf.local.home>
        <20170706130658.GC2511@lianli.shorne-pla.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 645
Lines: 25

On Thu, 6 Jul 2017 22:06:58 +0900
Stafford Horne <shorne@gmail.com> wrote:

> On Wed, Jul 05, 2017 at 12:25:06PM -0400, Steven Rostedt wrote:
> > On Tue,  4 Jul 2017 15:38:55 +0900
> > Masami Hiramatsu <mhiramat@kernel.org> wrote:
> >   
> > > +    local testlog=`mktemp $LOG_DIR/${testname}-log.XXXXXX`
> > > +  else
> > > +    local testlog=`/proc/self/fd/1`  
> > 
> > cute trick.  
> 
> Shouldn't this be:
> 
>    local testlog=/proc/self/fd/1
> 
> without the backticks and subshell? We just want to write to the stdout
> file not execute it.
> 
> Or am missing something.

Good eyes. I mistook those as quotes and not backticks.

-- Steve