Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752253AbdGFOKs (ORCPT ); Thu, 6 Jul 2017 10:10:48 -0400 Received: from verein.lst.de ([213.95.11.211]:60162 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751741AbdGFOKr (ORCPT ); Thu, 6 Jul 2017 10:10:47 -0400 Date: Thu, 6 Jul 2017 16:10:45 +0200 From: Christoph Hellwig To: Robin Murphy Cc: Tomasz Figa , "open list:IOMMU DRIVERS" , "linux-kernel@vger.kernel.org" , Christoph Hellwig , Marek Szyprowski , Greg Kroah-Hartman , Joerg Roedel , Will Deacon , Vineet Gupta , Hans-Christian Noren Egtvedt , Mitchel Humpherys , Krzysztof Kozlowski , Arnd Bergmann Subject: Re: [RFC PATCH 4/5] iommu/dma: Export non-static functions to use in modules Message-ID: <20170706141045.GA577@lst.de> References: <20170705071215.17603-1-tfiga@chromium.org> <20170705071215.17603-5-tfiga@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 559 Lines: 10 On Thu, Jul 06, 2017 at 12:09:45PM +0100, Robin Murphy wrote: > I suppose another option is to just make the IOMMU and DMA ops a > self-contained non-modular driver mirroring the VT-d/AMD-Vi IOMMUs - > AFAICS it shouldn't have to be all that tightly coupled to the IPU bus > code, the latter more or less just needs to create the appropriate IOMMU > device for the driver to find. I still haven't seen the driver code, but this seems to be best solution so far. Given that it's not a plug in device but part of an SOC that seems perfectly acceptable to me.