Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752011AbdGFQNW (ORCPT ); Thu, 6 Jul 2017 12:13:22 -0400 Received: from merlin.infradead.org ([205.233.59.134]:42328 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751751AbdGFQNU (ORCPT ); Thu, 6 Jul 2017 12:13:20 -0400 Date: Thu, 6 Jul 2017 18:13:02 +0200 From: Peter Zijlstra To: Laurent Dufour Cc: paulmck@linux.vnet.ibm.com, akpm@linux-foundation.org, kirill@shutemov.name, ak@linux.intel.com, mhocko@kernel.org, dave@stgolabs.net, jack@suse.cz, Matthew Wilcox , linux-kernel@vger.kernel.org, linux-mm@kvack.org, haren@linux.vnet.ibm.com, khandual@linux.vnet.ibm.com, npiggin@gmail.com, bsingharora@gmail.com, Tim Chen Subject: Re: [RFC v5 09/11] mm: Try spin lock in speculative path Message-ID: <20170706161302.aupbhvld3yew3cjl@hirez.programming.kicks-ass.net> References: <1497635555-25679-1-git-send-email-ldufour@linux.vnet.ibm.com> <1497635555-25679-10-git-send-email-ldufour@linux.vnet.ibm.com> <20170705185023.xlqko7wgepwsny5g@hirez.programming.kicks-ass.net> <3af22f3b-03ab-1d37-b2b1-b616adde7eb6@linux.vnet.ibm.com> <20170706144852.fwtuygj4ikcjmqat@hirez.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 525 Lines: 10 On Thu, Jul 06, 2017 at 05:29:26PM +0200, Laurent Dufour wrote: > Based on the benchmarks I run, it doesn't fail so much often, but I was > thinking about adding some counters here. The system is accounting for > major page faults and minor ones, respectively current->maj_flt and > current->min_flt. I was wondering if an additional type like async_flt will > be welcome or if there is another smarter way to get that metric. > > Feel free to advise. You could stick a tracepoint in, or extend PERF_COUNT_SW_PAGE_FAULTS*.